ListSites.AltitudeUnits char limit too short

[atn38]

currently character limit is 10, need to be 100 to match that of DataSetAttributes.Unit which is the only other place with units in metabase

I'll update this issue with a patch shortly, posting to alert people.

[atn38]

see 1276bba for patch40.

[gastil]

I do not understand. Not objecting, just want to understand. Altitude units are expected to be one of {feet, meters, miles, kilometers}. I cannot think of an altitude unit with more than 10 characters. So maybe Postgres complained that a foreign key to the unit dictionary needed to match the length of characters? Does EML actually use units in the schema like stmml units (customUnit or standardUnit)? I have only ever used <altitudeUnits>meter</altitudeUnits>. Perhaps a CHECK unitName in ('meters','kilometers','feet','miles') is better than an FK?

I looked at common patterns of usage. In 30 scopes (just Lter, not edi), the following units are used: meter, meters, foot, Foot_US.

[atn38]

Ah yes, I forgot to mention that I did run into an error when editing the EMLUnitDictionary. It complained that what I'm editing makes it too long because AltitudeUnits only has a 10 char limit. Sorta preemptive action, I thought. Nothing happens if I leave the units alone. Weird.

…

On Thu, Nov 21, 2019 at 4:56 PM Gastil ***@***.***> wrote: I do not understand. Not objecting, just want to understand. Altitude units are expected to be one of {feet, meters, miles, kilometers}. I cannot think of an altitude unit with more than 10 characters. So maybe Postgres complained that a foreign key to the unit dictionary needed to match the length of characters? Does EML actually use units in the schema like stmml units (customUnit or standardUnit)? I have only ever used <altitudeUnits>meter</altitudeUnits>. Perhaps a CHECK unitName in ('meters','kilometers','feet','miles') is better than an FK? I looked at common patterns of usage. In 30 scopes (just Lter, not edi), the following units are used: meter, meters, foot, Foot_US. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#91?email_source=notifications&email_token=AKAZD5TQIMIGWNMEM4W3JVLQU4G3RA5CNFSM4JQIZ3CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE357YA#issuecomment-557309920>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKAZD5WS5ODQGUXV2ORQA23QU4G3RANCNFSM4JQIZ3CA> .

[atn38]

closing