From 6d3a9fd578a02e4f2a591a3e540ab98dcaa485cf Mon Sep 17 00:00:00 2001 From: Markus Demleitner Date: Thu, 8 Feb 2024 17:26:45 +0100 Subject: [PATCH] enable_pdfjs is now default true. Hence, amending the viewpdf documentation that you must turn it off for viewpdf to work. --- CHANGELOG.md | 1 + lib/viewpdf.lua | 3 ++- lib/webview.lua | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 791a9ec4b..8340341e8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ ### Added - Manage dom events with luakit signals. +- An enable_pdfjs setting to go back to letting viewpdf handle PDFs. ### Changed diff --git a/lib/viewpdf.lua b/lib/viewpdf.lua index d97061100..1f4e767c9 100644 --- a/lib/viewpdf.lua +++ b/lib/viewpdf.lua @@ -1,7 +1,8 @@ --- Automatic PDF viewing. -- -- This module automatically downloads PDF files to the luakit cache directory, --- and opens them with `xdg-open`. +-- and opens them with `xdg-open`. You must disable the enable_pdfjs +-- setting for this to work. -- -- @module viewpdf -- @copyright 2016 Aidan Holm diff --git a/lib/webview.lua b/lib/webview.lua index 8210be19c..353ec8330 100644 --- a/lib/webview.lua +++ b/lib/webview.lua @@ -575,7 +575,7 @@ local webview_settings = { }, ["application.enable_pdfjs"] = { type = "boolean", - default = false, + default = true, desc = [=[ Whether to load PDFs in a built-in javascript renderer. The default is to pass them on to the OS. This setting