Skip to content
This repository has been archived by the owner. It is now read-only.

[rfc] remove names.scan() #61

Merged
merged 1 commit into from May 11, 2013
Merged

[rfc] remove names.scan() #61

merged 1 commit into from May 11, 2013

Conversation

@phi-gamma
Copy link
Member

@phi-gamma phi-gamma commented May 11, 2013

As far as I can grep, names.scan() alias scan_external_dir() is used nowhere and undocumented. There’s no test for it either. I’ve read some old posts on mailing lists and tex-sx that would suggest was intended to be called from fontspec. However, fontspec seems to do fine without it, so I guess we might as well drop the function.

eroux added a commit that referenced this issue May 11, 2013
[rfc] remove ``names.scan()``
@eroux eroux merged commit 9d88759 into lualatex:master May 11, 2013
@khaledhosny
Copy link

@khaledhosny khaledhosny commented May 12, 2013

Well, it was meant to allow people to call fonts by name when using fontspec’s ExternalLocation, but it never got implemented. Not a reason to drop it IMO, but it can be moved to the new aux library and be a documented feature.

@phi-gamma
Copy link
Member Author

@phi-gamma phi-gamma commented May 12, 2013

okay, I’ll keep it, then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants