Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Something is introducing line breaks in bash files #39

Closed
XanderStrike opened this issue Jul 13, 2020 · 1 comment · Fixed by #40
Closed

Something is introducing line breaks in bash files #39

XanderStrike opened this issue Jul 13, 2020 · 1 comment · Fixed by #40

Comments

@XanderStrike
Copy link

When writing long lines in bash scripts using the latest version of this config, newlines are introduced while writing long lines in bash scripts.

These line breaks aren't escaped, so if you don't notice what's happened your script will break.
@XanderStrike
Copy link
Author

Discovered today that set textdwidth=0 fixes the behavior.

Looks like this was added in this commit: https://github.com/luan/nvim/blame/28fe3ebacb819d16d955431dc46a8de3463fe0fc/include/basic.vim#L24

I think it's fine to do this in markdown/docs files, but this shouldn't be happening in code. Leave it to the linter to enforce line length rules.

XanderStrike pushed a commit to XanderStrike/nvim that referenced this issue Jul 14, 2020
Remove textwidth limitation
690675a 
resolves luan#39

This was adding newlines to many files where they shouldn't be, breaking certain kinds of bash scripts. Enforcing line length should be the responsibility of a language-specific linter, not a global rule for the editor.
XanderStrike pushed a commit to XanderStrike/nvim that referenced this issue Jul 14, 2020
remove textwidth limitation
0e98b8d 
resolves luan#39

This was adding newlines to many files where they shouldn't be, breaking certain kinds of bash scripts. Enforcing line length should be the responsibility of a language-specific linter, not a global rule for the editor.
@XanderStrike XanderStrike mentioned this issue Jul 14, 2020
Merged
@luan luan closed this as completed in #40 Jul 14, 2020
XanderStrike pushed a commit to XanderStrike/nvim that referenced this issue Jul 14, 2020
remove textwidth limitation
6cf16c6 
resolves luan#39

This was adding newlines to many files where they shouldn't be, breaking certain kinds of bash scripts. Enforcing line length should be the responsibility of a language-specific linter, not a global rule for the editor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove textwidth limitation XanderStrike/nvim
1 participant
@XanderStrike