Skip to content

Commit 6693a4b

Browse files
authored
Fix Android support in bump_version.sh (#10836)
1 parent e86c93f commit 6693a4b

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

build/android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Top-level build file where you can add configuration options common to all sub-projects/modules.
22

33
project.ext.set("versionMajor", 5) // Version Major
4-
project.ext.set("versionMinor", 3) // Version Minor
4+
project.ext.set("versionMinor", 4) // Version Minor
55
project.ext.set("versionPatch", 0) // Version Patch
66
project.ext.set("versionExtra", "-dev") // Version Extra
77
project.ext.set("versionCode", 30) // Android Version Code

util/bump_version.sh

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ prompt_for_number() {
2121
# * Commit the changes
2222
# * Tag with current version
2323
perform_release() {
24+
RELEASE_DATE=$(date +%Y-%m-%d)
25+
2426
sed -i -re "s/^set\(DEVELOPMENT_BUILD TRUE\)$/set(DEVELOPMENT_BUILD FALSE)/" CMakeLists.txt
2527

28+
sed -i 's/project.ext.set("versionExtra", "-dev")/project.ext.set("versionExtra", "")/' build/android/build.gradle
2629
sed -i -re "s/\"versionCode\", [0-9]+/\"versionCode\", $NEW_ANDROID_VERSION_CODE/" build/android/build.gradle
2730

2831
sed -i '/\<release/s/\(version\)="[^"]*"/\1="'"$RELEASE_VERSION"'"/' misc/net.minetest.minetest.appdata.xml
29-
30-
RELEASE_DATE=`date +%Y-%m-%d`
31-
3232
sed -i 's/\(<release date\)="[^"]*"/\1="'"$RELEASE_DATE"'"/' misc/net.minetest.minetest.appdata.xml
3333

3434
git add -f CMakeLists.txt build/android/build.gradle misc/net.minetest.minetest.appdata.xml
@@ -47,20 +47,24 @@ perform_release() {
4747
back_to_devel() {
4848
echo 'Creating "return back to development" commit'
4949

50+
# Update CMakeList.txt versions
5051
sed -i -re 's/^set\(DEVELOPMENT_BUILD FALSE\)$/set(DEVELOPMENT_BUILD TRUE)/' CMakeLists.txt
51-
5252
sed -i -re "s/^set\(VERSION_MAJOR [0-9]+\)$/set(VERSION_MAJOR $NEXT_VERSION_MAJOR)/" CMakeLists.txt
53-
5453
sed -i -re "s/^set\(VERSION_MINOR [0-9]+\)$/set(VERSION_MINOR $NEXT_VERSION_MINOR)/" CMakeLists.txt
55-
5654
sed -i -re "s/^set\(VERSION_PATCH [0-9]+\)$/set(VERSION_PATCH $NEXT_VERSION_PATCH)/" CMakeLists.txt
5755

58-
sed -i -re "1s/[0-9]+\.[0-9]+\.[0-9]+/$NEXT_VERSION/g" doc/menu_lua_api.txt
56+
# Update Android versions
57+
sed -i 's/set("versionExtra", "")/set("versionExtra", "-dev")/' build/android/build.gradle
58+
sed -i -re "s/set\(\"versionMajor\", [0-9]+\)/set(\"versionMajor\", $NEXT_VERSION_MAJOR)/" build/android/build.gradle
59+
sed -i -re "s/set\(\"versionMinor\", [0-9]+\)/set(\"versionMinor\", $NEXT_VERSION_MINOR)/" build/android/build.gradle
60+
sed -i -re "s/set\(\"versionPatch\", [0-9]+\)/set(\"versionPatch\", $NEXT_VERSION_PATCH)/" build/android/build.gradle
5961

62+
# Update doc versions
63+
sed -i -re "1s/[0-9]+\.[0-9]+\.[0-9]+/$NEXT_VERSION/g" doc/menu_lua_api.txt
6064
sed -i -re "1s/[0-9]+\.[0-9]+\.[0-9]+/$NEXT_VERSION/g" doc/client_lua_api.txt
6165

62-
git add -f CMakeLists.txt doc/menu_lua_api.txt doc/client_lua_api.txt
63-
66+
# Commit
67+
git add -f CMakeLists.txt build/android/build.gradle doc/menu_lua_api.txt doc/client_lua_api.txt
6468
git commit -m "Continue with $NEXT_VERSION-dev"
6569
}
6670
##################################

0 commit comments

Comments
 (0)