-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use formspec version 6 in the main menu #13761
Use formspec version 6 in the main menu #13761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on my Android device with default Minetest scaling settings. Here is a screenshot:
The left side of the tab looks very crowded, although there is still free space at the bottom. The checkboxes even overlap each other: If you zoom in, you can see that they are wider than they are tall. I think more vertical spacing is needed.
This was slightly better with the old version of the tab:
In particular, the checkboxes did not overlap, but were nearly exactly aligned.
Looks good to me otherwise, but I can't look at the code right now. (The "Open Settings" button got even more ugly, but that doesn't matter for obvious reasons.)
I forgot to increase the spacing between the checkboxes to account for the move to real coords, done now |
What about this? grorp@4c6f28a It makes the left side use the full available vertical space again, i.e. the bottom of the last field is at |
Looks good, applied that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from that.
Co-authored-by: Gregor Parzefall <82708541+grorp@users.noreply.github.com>
This makes all the tabs in the mainmenu use formspec version 6 and real coordinates. To do this, the local tab has been updated to work with real coordinates
This is a prerequisite to replacing the settings tab with a settings button, part of #13476
To do
This PR is Ready for Review
How to test