Allow toggling fullscreen without restart and add keybind#14714
Conversation
|
This is much easier to implement now that we use borderless fullscreen |
What actually makes it much easier is that we now have an Irrlicht fork and the SDL device. Now that we have these two things, this PR automatically works with "real" fullscreen too if we tell SDL to enable it. |
Cannot reproduce (Fedora 39 "Workstation", GNOME 45, Wayland). I think indeed not our fault.
That should depend on your |
Well I'm on X11, but I think the source of this behavior is more likely in SDL.
👍 |
Fixes #2732, opened in 2015, closed as non-trivial in 2017 (because there was no Irrlicht fork and no SDL device back then)
New users can easily think that the
fullscreensetting is broken because it's only applied after a restart and this isn't even documented.This PR allows toggling
fullscreenvia the settings menu without a restart. For convenience, there's also a new keybind calledkeymap_fullscreen(F11 by default). As a bonus,window_maximizedis now applied immediately too.To do
This PR is a Ready for Review.
How to test
Change the
fullscreenandwindow_maximizedsettings. See that Minetest reacts immediately.Press F11. See that fullscreen mode is toggled and that the fullscreen checkbox in the settings is updated too.