Show IME candidate list in Windows - #14942
Merged
Merged
Conversation
sfan5
approved these changes
Aug 9, 2024
sfan5
left a comment
sfan5
left a comment
Member
There was a problem hiding this comment.
Works on Linux.
It's a weird choice by SDL to disable these by default.
sfan5
added
One approval ✅ ◻️
1 approval rule
Mahoyomu
pushed a commit
to Mahoyomu/minetest
that referenced
this pull request
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets the appropriate SDL hints to make Windows show the candidate list when an IM is active.
See description.
SDL_SetHintNo.
No.
This is a bugfix as some IMs require a candidate list (or a similar feature) to be reasonably usable.
To do
This PR is Ready for Review.
How to test
In Windows, check that a candidate list is shown when an IM is used and text input is active.