Add glTF STEP interpolation support#15525
Merged
Merged
Conversation
appgurueu
added
@ Script API
Feature ✨
appgurueu
force-pushed
the
feat/gltf-const-interp
branch
from
December 12, 2024 15:28
2efbc64 to
8d65720
Compare
appgurueu
removed
the
Waiting (on dependency)
sfan5
approved these changes
Dec 24, 2024
sfan5
left a comment
sfan5
left a comment
Member
There was a problem hiding this comment.
read the spec and our code, should work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for glTF STEP interpolation (no interpolation). It turns out many models require this (often unnecessarily for channels with singular values because Blender apparently forcibly creates STEP channels for unanimated properties by default). Related to a point on #15410.
How to test
Spawn the simple skin step test entity, compare it against the linearly interpolated one. Observe no interpolation.