[no squash] CAO 'node' visual#15683
Merged
Merged
Conversation
Contributor
|
Is this going to support scale? (making the node bigger/smaller) |
Member
Author
|
It will support |
Contributor
|
Tried with random falling nodes and have observed no difference in behavior, with simpler code. Cool. |
sfan5
added a commit
to sfan5/luanti
that referenced
this pull request
Jan 20, 2025
sfan5
added a commit
to sfan5/luanti
that referenced
this pull request
Feb 15, 2025
sfan5
added a commit
to sfan5/luanti
that referenced
this pull request
Feb 15, 2025
sfan5
added a commit
to sfan5/luanti
that referenced
this pull request
Feb 15, 2025
SmallJoker
self-requested a review
February 15, 2025 14:15
SmallJoker
reviewed
Feb 21, 2025
SmallJoker
left a comment
Member
There was a problem hiding this comment.
Tested drawtypes:
- degrotate rooted plantlike
- normal
- wallmounted
- facedir
- 4dir
- color4dir
- colorfacedir
- colorwallmounted
- colordegrotate
Works well.
This greatly simplifies the code at the expense of some falling nodes not showing up on older clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements, closes #10722
To do
This PR is Ready for Review.
How to test
This code gives you a tool that duplicates an arbitrary node as entity:
And this one gives you a tool that can make any node fall: