Conversation
sfan5
added
@ Server / Client / Env.
Feature ✨
sfence
approved these changes
Feb 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so that if you have IPv6 and enable server announcements you automatically arrive at a configuration that actually works (domain or not).
Previously if you had IPv6 configured on your server and maybe even a domain, the server list would reject you because the server can't actually be reached over IPv6 by default.
Implications:
get_player_informationwill look like::ffff:1.2.3.4by default. I think most mods handle this.Note: this PR was written on a train.
To do
This PR is a Ready for Review.