Make Sneak and Aux1 optionally togglable#15785
Merged
Merged
Conversation
y5nw
added
Feature ✨
This comment was marked as resolved.
This comment was marked as resolved.
grorp
self-requested a review
February 28, 2025 03:14
grorp
reviewed
Mar 1, 2025
grorp
added
Action / change needed
y5nw
reviewed
Mar 1, 2025
y5nw
left a comment
y5nw
left a comment
Contributor
There was a problem hiding this comment.
(Code review only. I'm fine with both approaches so I'll leave it to grorp to decide whether this is better.)
y5nw
reviewed
Mar 2, 2025
This makes the Sneak and Aux1 keys toggle-actions, if toggling them is enabled in settings. Since this is done in the game logic, it doesn't affect things like sneak-clicking nodes in inventories, as that uses keycodes.cpp instead.
This function call restarts the console application, which can make Visual Studio lose sight of it and prevent debugging. Using Visual Studio Community 2022.
This is handled by another pr.
Will be put in another PR
This is handled by another pr.
grorp
reviewed
Mar 3, 2025
Also removes braces in the if else statement
Contributor
Author
|
Btw how is squashing handled, does GitHub sort that out or should I it be done manually |
Contributor
Github handles that (there is a "Squash and merge" button for us). |
y5nw
self-requested a review
March 3, 2025 23:13
Zughy
removed
the
Action / change needed
Contributor
|
Do we want to also show feedback to users (e.g. "Aux1 held down"/"Aux1 released")? IMO you should generally be able to tell that from interaction (e.g. moving down while flying) so I'm not sure whether it is needed. |
Contributor
Author
|
Yeah I agree, I think that'd be overkill and contribute to clutter. The user knows if they enabled toggling, and will see whether sneak/aux1 is toggled the moment they move in most cases |
grorp
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
This PR adds two accessibility settings to the control options for toggling
sneakandaux1.When these are enabled, their respective keys in-game will toggle when you press them. This lets you e.g. press
sneakto toggle on sneaking until you're done building over a ledge or bridging, and then press it again to stop sneaking, instead of having to keep the button pressed for the entire duration.This addresses the same issue as #15234, but uses a more generic and platform-independent implementation, as suggested in the comments, which will also work for mobile. The implementation is different enough that I thought it best to open a new PR.
Notably, this doesn't affect how the
aux1andsneakkeys are read by the formspec, because it only changes the input handling ofgame.cpp, notkeycodes.cpp. I imagine that would be outside the behaviour most people expect and want from this option, and it might also interfere with mobile formspec interaction.Environment
I'm compiling on Windows 11, with Visual Studio Community 2022 (Microsoft now restricts access to the 2019 version).
If more specific information is desired let me know.
To do
This PR is Ready for Review.
Determine if toggling should be added tokeycodes.cppas well, which is used by the inventory. Currently it only affects player movement, e.g. shift-clicking a node in the inventory works as normal regardless of if shift is toggled for the players movement. Choosing to do this might interfere with item managing on mobile.How to test
Launch the game, go to
Options->Controls->Generaland enableToggle aux1 keyandToggle sneak key.Then start any world and press the sneak key, release it and it will persist. Pressing it again will stop the player from sneaking.