Skip to content

[nosq] skip decos outside of y limits for faster decoration placement - #15856

Merged
sfan5 merged 2 commits into
luanti-org:masterfrom
kno10:deco-ylimits
Mar 3, 2025
Merged

[nosq] skip decos outside of y limits for faster decoration placement#15856
sfan5 merged 2 commits into
luanti-org:masterfrom
kno10:deco-ylimits

Conversation

@kno10

@kno10 kno10 commented Mar 1, 2025

Copy link
Copy Markdown
Contributor
  • placeDeco only ever returns 0, hence placeAllDecos also. Use void then.
  • some trivial code cleanups
  • skip decorations whose ylimits do not overlap the current chunk. This helps in particular when multiple "dimensions" are implemented by verticals stacking (e.g., nether in voxelibre, mineclonia).

sfan5
sfan5 reviewed Mar 1, 2025
View reviewed changes
Comment thread src/mapgen/mg_decoration.cpp
@kno10 kno10 changed the title Skip decos outside of y limits for faster decoration placement [nosq] skip decos outside of y limits for faster decoration placement Mar 1, 2025
@kno10
kno10 requested a review from sfan5 March 1, 2025 18:39
sfan5
sfan5 approved these changes Mar 1, 2025
View reviewed changes

@sfan5 sfan5 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfan5 sfan5 added One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Mar 1, 2025
@sfan5
sfan5 merged commit 6e99597 into luanti-org:master Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfan5 sfan5 sfan5 approved these changes

Assignees

No one assigned

Labels

@ Mapgen One approval ✅ ◻️ Performance Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kno10 @sfan5