Skip to content

[no sq] Increase strictness for item registration / overrides#15912

Merged
sfan5 merged 3 commits into
luanti-org:masterfrom
sfan5:metameta
Mar 19, 2025
Merged

[no sq] Increase strictness for item registration / overrides#15912
sfan5 merged 3 commits into
luanti-org:masterfrom
sfan5:metameta

Conversation

@sfan5

@sfan5 sfan5 commented Mar 16, 2025

Copy link
Copy Markdown
Member

see #15091
also: the discussion in #15910 and on IRC

Note: this breaks Voxelibre, because they try to register aliases a few seconds after the game starts.

To do

This PR is Ready for Review.

@sfan5 sfan5 added Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines @ Builtin labels Mar 16, 2025
@Zughy Zughy added the Bugfix 🐛 PRs that fix a bug label Mar 16, 2025
@sfan5 sfan5 changed the title Warn if metatable passed to itemdef registration function [no sq] Increase strictness for item registration / overrides Mar 16, 2025
@sfan5 sfan5 removed the Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines label Mar 16, 2025

@SmallJoker SmallJoker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I enabled a few of the commonly used mods for MTG. No breakages found.

$ grep "load_mod_" world.mt | grep "= mods/" | wc -l
157

Mineclonia works.
Repixture works.
VoxelLibre works

Comment thread builtin/game/register.lua
@sfan5 sfan5 merged commit a9a3b05 into luanti-org:master Mar 19, 2025
@sfan5 sfan5 deleted the metameta branch March 19, 2025 21:06
@kno10

kno10 commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

It does appear that this can crash VL due to the HELP/mcl_item_id mod, when some structure spawns with an enchanted item. I'm not sure what that mod is actually good for, it seems to hook into the tooltip system for addons to add some debugging tooltips and could simply be dropped. Mineclonia appears to have deleted that mod a year ago already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants