[no sq] Increase strictness for item registration / overrides#15912
Merged
Conversation
SmallJoker
approved these changes
Mar 19, 2025
SmallJoker
left a comment
Member
There was a problem hiding this comment.
I enabled a few of the commonly used mods for MTG. No breakages found.
$ grep "load_mod_" world.mt | grep "= mods/" | wc -l
157
Mineclonia works.
Repixture works.
VoxelLibre works
Contributor
|
It does appear that this can crash VL due to the |
This was referenced Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #15091
also: the discussion in #15910 and on IRC
Note: this breaks Voxelibre, because they try to register aliases a few seconds after the game starts.
To do
This PR is Ready for Review.