Optimize name-id-lookup for mapblock serialization - #16000
Merged
sfan5 merged 6 commits intoApr 14, 2025
Merged
Conversation
sfan5
reviewed
Apr 11, 2025
sfan5
self-requested a review
April 12, 2025 08:41
sfan5
reviewed
Apr 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interesting side-node: It looks to me like loops over all nodes in a mapblock are completely rolled out. Idk if this is fine or not.Edit: Oops, found the jmp now.To do
This PR is a Ready for Review.
How to test
time luanti --server --recompress --worldname name_of_your_worlduser 0m43,924s
sys 0m2,004s
user 0m44,164s
sys 0m1,665s
user 0m50,291s
sys 0m1,936s
user 0m35,712s
sys 0m1,894s
user 0m36,517s
sys 0m1,686s
user 0m37,303s
sys 0m1,793s