[manual merge] glTF improvements - #16086
Merged
appgurueu merged 2 commits intoApr 26, 2025
Merged
Conversation
appgurueu
added
Trivial
appgurueu
changed the title
Contributor
Author
|
I added a third commit. You can test it by observing that the frog still works. |
appgurueu
force-pushed
the
fix/gltf-ignore-skinned-transform
branch
from
April 25, 2025 21:37
a3276ac to
706dc96
Compare
sfan5
added
One approval ✅ ◻️
and removed
Trivial
appgurueu
force-pushed
the
fix/gltf-ignore-skinned-transform
branch
from
April 26, 2025 14:03
706dc96 to
bd38ce2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit is the trivial bugfix.
Second commit is for testing only, revert before merge: The model used for testing is NC-licensed.
I've also committed the JSON so you can conveniently view this using the glTF validator extension in VS Code.
How to test
Check out this PR, spawn eddie (https://sketchfab.com/3d-models/ai2u-catgirl-eddie-official-game-character-6f4d2278b2ba4c7f86e3a0c5a0491334), confirm that it looks correct:
it will not look correct without this PR.
Confirm that other glTF test models still work as expected.
c.f. https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#joint-hierarchy:
note that Eddie gets a warning in the glTF validator for this due to having non-identity transformed skinned nodes.