Do not block in httpfetch_request_clear() - #16303
Merged
Merged
Conversation
sfan5
added
Trivial
SmallJoker
approved these changes
Jul 3, 2025
SmallJoker
left a comment
SmallJoker
left a comment
Member
There was a problem hiding this comment.
Fun fact: an unreachable nameserver also locks up sudo for a few seconds because it cannot resolve the (local) hostname. It's best not to close the editor after making changes.
I can now press "Connect" in the main menu, results in an address resolver error after a while.
The server list returns CurlFetchThread blocked for 13197ms and 10033ms respectively (1x geoip, 1x server list). Singleplayer does indeed still work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #16272
To do
This PR isReady for Review.
How to test
/etc/resolv.confto only contain a single nameserver that doesn't workyou should be able to start a singleplayer session normally.
Luanti will still block upon exit and the "WARNING[CurlFetch]: CurlFetchThread blocked for" message should appear.