Skip to content

ParticleSpawner: Fix crash caused by empty texture - #16351

Merged
sfan5 merged 2 commits into
luanti-org:masterfrom
SmallJoker:pr_16351_empty_texture_particle_fix
Jul 22, 2025
Merged

ParticleSpawner: Fix crash caused by empty texture#16351
sfan5 merged 2 commits into
luanti-org:masterfrom
SmallJoker:pr_16351_empty_texture_particle_fix

Conversation

@SmallJoker

Copy link
Copy Markdown
Member

no_texture.png is now used as a fallback (if available), like already seen with registered items with empty 'inventory_image'.

Fixes #16345

To do

This PR is Ready for Review.

How to test

  1. Use 3rd person perspective
  2. Use the worldedit commands mod
  3. //lua pos=player:get_pos(); pos.y=pos.y+2; core.add_particlespawner{pos=pos,time=4,animation={type="vertical_frames"}}
  4. A particle must show up on top of your head, indicating failure by using no_texture.png.

no_texture.png is now used as a fallback (if available), like already
seen with registered items with empty 'inventory_image'.
Comment thread src/noise.cpp

@sfan5 sfan5 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested, LGTM

@sfan5
sfan5 merged commit d60f909 into luanti-org:master Jul 22, 2025
15 of 17 checks passed
@SmallJoker
SmallJoker deleted the pr_16351_empty_texture_particle_fix branch July 27, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a segfault related to animations in particlespawners

2 participants