Add formspec box color documentation to style section - #16438
Merged
Conversation
Zughy
added
the
Trivial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you use styling for a box element, you may miss that you have to remove the color specification, if you only read the documentation about styling, and not for the element itself.
So with this PR it is documented at two places such that people don't miss it that easily anymore.
The first existing one is here:
luanti/doc/lua_api.md
Line 3324 in 36b5374
(IMO, documenting it in the styling section is more important, but it doesn't hurt to have it two times, I think.)
This is actually a problem, see here: https://forum.luanti.org/viewtopic.php?t=31937
To do
This PR is Ready for Review.
How to test
Read