Lua Toolbox merge

[Etiene]

A brand new dump of LuaToolbox's db will be needed (cc @catwell)

For transferring endorsements to Followings I added a new tab on the user settings explaining the situation with a link for the transfer. I have an issue once the transfer is done though. I'm rendering the same view from a different action and this results on the url changing when you get the success message. I don't particularly like that but I didn't know how to do otherwise and this might need a touch-up. Not a huge deal, though.

When importing current labels I was not exactly sure how to access Lapis' model module in a simple script. So for the moment the functions are in a helper class and I tested and ran them using the specs.

I also added the labels to the front page, but I'm not sure if it's pretty enough.

For the moment only module owners can add or remove labels from a module. There's no way to add new labels yet, only to select from existing labels.

Screenshots of my local system:

|--> Owner's view: Add label link is on owner's menu for the moment

[catwell]

This is great. I still miss one of the main features from Toolbox though: the ability to see the list of modules endorsed / followed by someone and a list of people endorsing / following a module. If this isn't available then followings cannot replace endorsements.

The first one could be added below the list of modules authored by a user on their user page and the second one could be accessible by clicking here:

Regarding DB dumps, if I give you a dump and at a later time another one, can you apply the changes? I am starting to think about exactly when I should shut Toolbox down.

[Etiene]

the ability to see the list of modules endorsed / followed by someone and a list of people endorsing

oops! :) coming in soon :)

[catwell]

Awesome!

I am still wondering if "follows" and "endorsements" should be the same thing. On GitHub they are not (Follow would be Watch and Endorse would be Star). What do you think?

[Etiene]

I had this discussion with @leafo , the issue is that maybe this makes for too many verbs and features for the users to catch up for now and the current following feature doesn't do much for the moment, he suggested merging them up and I thought it was a good idea. @hishamhm suggested maybe we should rename the followings to something simpler, such as stars, so user engagement can come easier.

[catwell]

OK, it makes sense.

Regarding missing features, I also think that:

• Follow count should be visible in module lists (next to downloads)
• There should be a way to sort those lists by follows (and probably downloads too)

Regarding the transition, here is how I see it:

• Once this is ready, we decide on a date to shutdown Lua Toolbox.
• I will send an email to all Toolbox users, telling them that it is shutting down.
  • I will explain how it will be replaced by LuaRocks (including the import feature).
  • I will tell users to create accounts there if they haven't already.
• On the date we decided I will replace the Lua Toolbox website by a static page explaining this.
• I will generate a final DB dump that I will give you.

How does that sound?

[hishamhm]

Yes, my argument was that "follow" makes me think "no, I don't want to
receive email notifications", while "stars" are vague enough so that in
practice it has a community-defined meaning (see the old Twitter stars).

I also suggested that, if possible, it would be nice to import Github stars
from a project and add them up with the "local stars". This would help
populating project stars a lot.
On Mar 17, 2016 17:11, "Etiene Dalcol" notifications@github.com wrote:

I had this discussion with @leafo https://github.com/leafo , the issue
is that maybe this makes for too many verbs and features for the users to
catch up for now and the current following feature doesn't do much for the
moment, he suggested merging them up and I thought it was a good idea.
@hishamhm https://github.com/hishamhm suggested maybe we should rename
the followings to something simpler, such as stars, so user engagement can
come easier.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#86 (comment)

[Etiene]

@catwell sounds perfect to me!

[leafo]

assert error jumps out of the function, so this return is unnecessary