New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xamarin.Forms 2.3.3.152-pre2 Could not load type 'FFImageLoading.Forms.Droid.CachedImageRenderer' #313

Closed
jjchiw opened this Issue Sep 18, 2016 · 5 comments

Comments

Projects
None yet
5 participants
@jjchiw

jjchiw commented Sep 18, 2016

Hi!

I upgraded Xamarin.Forms to 2.3.3.152-pre2 and the application started to crash with.

System.TypeLoadException: Could not load type 'FFImageLoading.Forms.Droid.CachedImageRenderer' from assembly 'FFImageLoading.Forms.Droid, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'.

after CachedImageRenderer.Init(); I wanted to try the version 2.3.3.152-pre2 because of this bug https://forums.xamarin.com/discussion/comment/220535 that it seems its fixed in this version https://forums.xamarin.com/discussion/77854/xamarin-forms-2-3-3-pre2#latest (43530 - "[Android] Resuming app throws IllegalStateException from fragment manager" )

I just tested in android with FFImageLoading.Forms.Droid version 2.1.7

I downgrade to this version 2.3.2.127 and it's working again...

I think it's not that important since it's a pre of Xamarin.Forms

But well just to let it know

Thanks for the great library

@adrianknight89

This comment has been minimized.

Contributor

adrianknight89 commented Sep 18, 2016

@imkow

This comment has been minimized.

imkow commented Sep 19, 2016

yeh, I got the same problem

@kentcb

This comment has been minimized.

Contributor

kentcb commented Sep 21, 2016

Got the same problem and really keen to try the XF pre-release to resolve exactly the same issue as the OP. Will there be a pre-release of FFIL to address this?

@daniel-luberda

This comment has been minimized.

Member

daniel-luberda commented Sep 21, 2016

FFImageLoading.Forms.Droid/CachedImageRenderer.cs(15,15): Error CS0534: `FFImageLoading.Forms.Droid.CachedImageRenderer' does not implement inherited abstract member `Xamarin.Forms.Platform.Android.ViewRenderer<FFImageLoading.Forms.CachedImage,FFImageLoading.Forms.Droid.CachedImageView>.CreateNativeControl()' (CS0534) (FFImageLoading.Forms.Droid)

I think it's a Xamarin.Forms issue as it breaks compatibility with all other renderers. CreateNativeControl method should be defined as virtual, not abstract.

//EDIT: I'll push a fix soon.

@daniel-luberda

This comment has been minimized.

Member

daniel-luberda commented Sep 21, 2016

FFImageLoading 2.1.8-pre-146 nuget which contains discussed fixes released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment