Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upactivation: add logic to receive file-descriptors #30
Conversation
…ervices
This comment has been minimized.
This comment has been minimized.
|
@jabedude very good! I think clippy in Travis caught an actual issue with your octal constants. Other than that, I'm fine with merging this. I only have a few final bikesheddings on naming:
|
This comment has been minimized.
This comment has been minimized.
|
@jabedude I think we can also freely bump Rust minimum version, it's currently at 1.31.0 for no specific reason. |
This comment has been minimized.
This comment has been minimized.
|
@lucab That's great to hear!
|
86d3dde
to
0c1c0cf
This comment has been minimized.
This comment has been minimized.
|
@lucab I've been fighting the linter and I can't get one check to pass. |
This comment has been minimized.
This comment has been minimized.
|
@jabedude that required updating Travis config. I've pushed a commit on your branch, CI is green now. Thanks for the code, this LGTM. |
jabedude commentedNov 13, 2019
Initial PR for #29, please review and let me know what you think.