Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate errors to the modern thiserror #7

Merged
merged 2 commits into from Jan 11, 2020
Merged

Conversation

@nagisa
Copy link
Collaborator

nagisa commented Jan 8, 2020

Fixes #6

@nagisa

This comment has been minimized.

Copy link
Collaborator Author

nagisa commented Jan 8, 2020

NB: this is an API-breaking change.

@nagisa nagisa force-pushed the nagisa:error-cleanup branch from b5abbbd to 745dd18 Jan 8, 2020
@nagisa

This comment has been minimized.

Copy link
Collaborator Author

nagisa commented Jan 9, 2020

@lucab btw if you want I can take over maintaining this crate.

before_script:
- bash -c 'if [[ "$TRAVIS_RUST_VERSION" == "$CLIPPY_RUST_VERSION" ]]; then

This comment has been minimized.

Copy link
@lucab

lucab Jan 10, 2020

Owner

I usually keep this pattern to avoid breaking master when new clippy lints are introduced. Would it be fine for you to keep a pinned toolchain for clippy?

@lucab

This comment has been minimized.

Copy link
Owner

lucab commented Jan 10, 2020

Happy to both land this, and give you github and crates.io access. I've left just a minor comment on the PR.
For reference, if your consumer is already using the nix crate, they recently added memfd support too: https://docs.rs/nix/0.16.1/nix/sys/memfd/index.html

@nagisa nagisa force-pushed the nagisa:error-cleanup branch from ee0d0a0 to 0b72c4e Jan 10, 2020
@nagisa nagisa force-pushed the nagisa:error-cleanup branch from 0b72c4e to 4539dcd Jan 10, 2020
@nagisa

This comment has been minimized.

Copy link
Collaborator Author

nagisa commented Jan 10, 2020

Should be good to go now.


I don’t exactly like nix the crate much. Used it for something else in the past and ended up moving away from it for multiple reasons.

@lucab
lucab approved these changes Jan 11, 2020
Copy link
Owner

lucab left a comment

LGTM

@lucab lucab merged commit 5bb07b6 into lucab:master Jan 11, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nagisa nagisa deleted the nagisa:error-cleanup branch Jan 11, 2020
@nagisa

This comment has been minimized.

Copy link
Collaborator Author

nagisa commented Jan 11, 2020

Can you please release a version with this?

@lucab lucab mentioned this pull request Jan 11, 2020
@lucab

This comment has been minimized.

Copy link
Owner

lucab commented Jan 11, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.