Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign error in the calculation of the errors on the Stokes paramaters #705

Closed
lucabaldini opened this issue May 24, 2023 · 2 comments
Closed

Sign error in the calculation of the errors on the Stokes paramaters #705

lucabaldini opened this issue May 24, 2023 · 2 comments

Comments

@lucabaldini
Copy link
Owner

This was pointed out by Fabio in issue #703

I noted something that I can't understand in line 496-497 of kislat2015.py in xStokesAnalysis.normalized_stokes_parameters:

QN_ERR[mask] = QN[mask] * numpy.sqrt(Q_REL_ERR**2. + I_REL_ERR**2.)
UN_ERR[mask] = UN[mask] * numpy.sqrt(U_REL_ERR**2. + I_REL_ERR**2.)

This means that, when QN or UN are negative, also their error is negative.
@lucabaldini
Copy link
Owner Author

Pull request: #706

@lucabaldini
Copy link
Owner Author

Shipped in 30.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucabaldini