Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Hide permissions if inherits from page is selected #12

Closed
lucabriguglia opened this issue Oct 6, 2016 · 17 comments
Closed

Hide permissions if inherits from page is selected #12

lucabriguglia opened this issue Oct 6, 2016 · 17 comments
Assignees
@subtata-emfluence
Labels
enhancement

Comments

@lucabriguglia
Copy link
Owner

In module settings hide role grid if inherits from page is selected.
@subtata-emfluence
Copy link
Collaborator

Thank you! [😊]

Regards,
Subrata Sarkar
Emfluence

+12025069125, +12025563514
Alternate email: niladri.sirkar@gmail.com

*** Save tree! Save nature!! Save our Planet!!!

From: Luca Briguglia notifications@github.com
Sent: Thursday, October 6, 2016 11:15:45 PM
To: weapsy/Weapsy
Cc: Subrata Sarkar; Mention
Subject: Re: [weapsy/Weapsy] Hide permissions if inherits from page is selected (#12)

Assigned #12#12 to @subtata-emfluencehttps://github.com/subtata-emfluence.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/12#event-815141331, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFQ0WE7Wh25oFAZh6LvMqtvoF0zS6mgWks5qxTPJgaJpZM4KQOSF.

subtata-emfluence referenced this issue in subtata-emfluence/Weapsy Oct 12, 2016
@emfluenceindia
Issue #12 completed: 'Hide permissions if inherits from page is selec…
ed5cc73 
…ted'
@emfluenceindia
Copy link
Contributor

emfluenceindia commented Oct 12, 2016 •
edited

Done and pushed to a new branch module-management created from master. Added new script file module-settings.js under js/pages/.

Before working on this issue the checkbox was checked by default on page load. Because now the toggle functionality is added and Role grid is visible by default, I have made the checkbox to remain unchecked when page loads. If clicked (checked), the Role Grid disappears. It appears on unchecking the checkbox once again. Let me know if this works.

@lucabriguglia
Copy link
Owner Author

Sorry but the checkbox should be checked by default because modules should inherit permissions from page unless specified ;-)

@emfluenceindia
Copy link
Contributor

Ok, in that case the role grid will stay hidden at page load, right?

@lucabriguglia
Copy link
Owner Author

Right

subtata-emfluence referenced this issue in subtata-emfluence/Weapsy Oct 12, 2016
@emfluenceindia
Issue #12: Updated checkbox checked status and role-grid visibility o…
9522a55 
…n page load.
subtata-emfluence referenced this issue in subtata-emfluence/Weapsy Oct 12, 2016
@emfluenceindia
Issue #12: Updated role-grid visibility and checkbox checked status a…
fb202e4 
…t page load
@emfluenceindia
Copy link
Contributor

Done. Please let me know if it is OK now.
One other thing I have just realized that initially you made me a member of Weapsy and now have taken it away. Although this is not a big deal, just wanted to know. :)

@lucabriguglia
Copy link
Owner Author

This user is a member of the team: subtata-emfluence.
Are you using two different users?

@emfluenceindia
Copy link
Contributor

Ah! may be. :) I will try and fix.

@subtata-emfluence
Copy link
Collaborator

Hi, what is the next task coming up? Waiting ... [😊]

Also were the changes I made OK as per requirement? Please let me know.

Regards,
Subrata Sarkar
Emfluence

+12025069125, +12025563514
Alternate email: niladri.sirkar@gmail.com

*** Save tree! Save nature!! Save our Planet!!!

From: Subrata Sarkar notifications@github.com
Sent: Wednesday, October 12, 2016 7:35:51 PM
To: weapsy/Weapsy
Cc: Subrata Sarkar; Mention
Subject: Re: [weapsy/Weapsy] Hide permissions if inherits from page is selected (#12)

Ah! may be. :) I will try and fix.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/12#issuecomment-253222938, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFQ0WLC50eW-sZM06IRArD-izBLdqZIEks5qzOk_gaJpZM4KQOSF.

@lucabriguglia
Copy link
Owner Author

Hi!

I'm planning to create a long list of tasks, hopefully today o tomorrow :-)

@lucabriguglia
Copy link
Owner Author

Hi, can you please create a pull request?

@subtata-emfluence
Copy link
Collaborator

Hi, I am back to work finally! Will do a pull request today and look into the issue you assigned to me.

I am really sorry for the delays caused by me due to my illness [☹]

Regards,
Subrata Sarkar
Emfluence

+12025069125, +12025563514
Alternate email: niladri.sirkar@gmail.com

*** Save tree! Save nature!! Save our Planet!!!

From: Luca Briguglia notifications@github.com
Sent: Wednesday, November 2, 2016 12:57:52 AM
To: weapsy/Weapsy
Cc: Subrata Sarkar; Mention
Subject: Re: [weapsy/Weapsy] Hide permissions if inherits from page is selected (#12)

Hi, can you please create a pull request?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/12#issuecomment-257668277, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFQ0WBmM3lGKReYft7FZKkFSCE7P9u6Oks5q55K4gaJpZM4KQOSF.

@emfluenceindia
Copy link
Contributor

I don't see the branches on Github website which I created !

Regards,
Subrata Sarkar
Emfluence

+12025069125, +12025563514
Alternate email: niladri.sirkar@gmail.com

*** Save tree! Save nature!! Save our Planet!!!

From: subtata-emfluence notifications@github.com
Sent: Wednesday, November 2, 2016 10:10:33 AM
To: weapsy/Weapsy
Cc: Subrata Sarkar; Comment
Subject: Re: [weapsy/Weapsy] Hide permissions if inherits from page is selected (#12)

Hi, I am back to work finally! Will do a pull request today and look into the issue you assigned to me.

I am really sorry for the delays caused by me due to my illness [:(]

Regards,
Subrata Sarkar
Emfluence

+12025069125, +12025563514
Alternate email: niladri.sirkar@gmail.com

*** Save tree! Save nature!! Save our Planet!!!

From: Luca Briguglia notifications@github.com
Sent: Wednesday, November 2, 2016 12:57:52 AM
To: weapsy/Weapsy
Cc: Subrata Sarkar; Mention
Subject: Re: [weapsy/Weapsy] Hide permissions if inherits from page is selected (#12)

Hi, can you please create a pull request?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/12#issuecomment-257668277, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFQ0WBmM3lGKReYft7FZKkFSCE7P9u6Oks5q55K4gaJpZM4KQOSF.

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com//issues/12#issuecomment-257770988, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKj0plGxl1oKuBlQvTUuThi67yetpbVmks5q6BRBgaJpZM4KQOSF.

@subtata-emfluence
Copy link
Collaborator

Hi, I cannot create any pull request as I don;t see my branches. The only branch I can see is master. Need your help!

Regards,
Subrata Sarkar
Emfluence

+12025069125, +12025563514
Alternate email: niladri.sirkar@gmail.com

*** Save tree! Save nature!! Save our Planet!!!

From: Subrata Sarkar notifications@github.com
Sent: Wednesday, November 2, 2016 10:17:13 AM
To: weapsy/Weapsy
Cc: Subrata Sarkar; Mention
Subject: Re: [weapsy/Weapsy] Hide permissions if inherits from page is selected (#12)

I don't see the branches on Github website which I created !

Regards,
Subrata Sarkar
Emfluence

+12025069125, +12025563514
Alternate email: niladri.sirkar@gmail.com

*** Save tree! Save nature!! Save our Planet!!!

From: subtata-emfluence notifications@github.com
Sent: Wednesday, November 2, 2016 10:10:33 AM
To: weapsy/Weapsy
Cc: Subrata Sarkar; Comment
Subject: Re: [weapsy/Weapsy] Hide permissions if inherits from page is selected (#12)

Hi, I am back to work finally! Will do a pull request today and look into the issue you assigned to me.

I am really sorry for the delays caused by me due to my illness [:(]

Regards,
Subrata Sarkar
Emfluence

+12025069125, +12025563514
Alternate email: niladri.sirkar@gmail.com

*** Save tree! Save nature!! Save our Planet!!!

From: Luca Briguglia notifications@github.com
Sent: Wednesday, November 2, 2016 12:57:52 AM
To: weapsy/Weapsy
Cc: Subrata Sarkar; Mention
Subject: Re: [weapsy/Weapsy] Hide permissions if inherits from page is selected (#12)

Hi, can you please create a pull request?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/12#issuecomment-257668277, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFQ0WBmM3lGKReYft7FZKkFSCE7P9u6Oks5q55K4gaJpZM4KQOSF.

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com//issues/12#issuecomment-257770988, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKj0plGxl1oKuBlQvTUuThi67yetpbVmks5q6BRBgaJpZM4KQOSF.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/12#issuecomment-257771664, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFQ0WAoM6TtB5tM08M8mDLCkI-thmIe2ks5q6BXRgaJpZM4KQOSF.

@lucabriguglia
Copy link
Owner Author

I can see this commit: subtata-emfluence/Weapsy@ed5cc73

@emfluenceindia
Copy link
Contributor

Yes, but when I am trying to do a pull request I don't see any of the branches I created under Comparer dropdown which I can select and initiate the request. Can you please help me?

@subtata-emfluence subtata-emfluence mentioned this issue Nov 3, 2016
Open
@lucabriguglia
Copy link
Owner Author

Can you please try to create a pull request again?

lucabriguglia added a commit that referenced this issue Nov 11, 2016
@lucabriguglia
Issues #12, #13 and #14
3151ae1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@subtata-emfluence subtata-emfluence

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@subtata-emfluence @lucabriguglia @emfluenceindia