Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests #14

Merged
merged 3 commits into from May 19, 2017
Merged

Integration tests #14

merged 3 commits into from May 19, 2017

Conversation

lucapette
Copy link
Owner

@lucapette lucapette commented May 18, 2017

Fixes #13

But I would like to merge it after we solve #12 so we can add a case for that feature too. After all, that's the feature that made us realise we could have better coverage

@@ -44,7 +45,7 @@ func NewColumns(keys []string) (cols Columns, err error) {
}

if _, ok := generators[key]; !ok {
errors.WriteString(fmt.Sprintf("Unknown generator: %s.\n", key))
fmt.Fprintf(&errors, "Unknown generator: %s.\n", key)
Copy link
Owner Author

@lucapette lucapette May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KevinGimbel a tiny change to the code we just merged (together the the comment in the same file). I've recently realised that using a buffer with fmt.Fprintf reads better than using WriteString + fmt.Sprintf. At least I think it does :)

Copy link
Collaborator

@KevinGimbel KevinGimbel May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. It reads better and looks "simpler". 👍

@@ -191,7 +191,7 @@ func init() {
}

generators["domain.name"] = Generator{
Name: "domain.tld",
Name: "domain.name",
Copy link
Owner Author

@lucapette lucapette May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the integration tests caught this :) One of the tests would randomly fail because two generators had the same name. Funny finding

@lucapette lucapette merged commit 34e7b13 into master May 19, 2017
2 checks passed
@lucapette lucapette deleted the integration-tests branch May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants