Integration tests #14

Merged
merged 3 commits into from May 19, 2017

Conversation

2 participants
@lucapette
Owner

lucapette commented May 18, 2017

Fixes #13

But I would like to merge it after we solve #12 so we can add a case for that feature too. After all, that's the feature that made us realise we could have better coverage

@lucapette lucapette added the testing label May 18, 2017

lucapette added some commits May 18, 2017

@@ -44,7 +45,7 @@ func NewColumns(keys []string) (cols Columns, err error) {
}
if _, ok := generators[key]; !ok {
- errors.WriteString(fmt.Sprintf("Unknown generator: %s.\n", key))
+ fmt.Fprintf(&errors, "Unknown generator: %s.\n", key)

This comment has been minimized.

@lucapette

lucapette May 19, 2017

Owner

@kevingimbel a tiny change to the code we just merged (together the the comment in the same file). I've recently realised that using a buffer with fmt.Fprintf reads better than using WriteString + fmt.Sprintf. At least I think it does :)

@lucapette

lucapette May 19, 2017

Owner

@kevingimbel a tiny change to the code we just merged (together the the comment in the same file). I've recently realised that using a buffer with fmt.Fprintf reads better than using WriteString + fmt.Sprintf. At least I think it does :)

This comment has been minimized.

@kevingimbel

kevingimbel May 19, 2017

Collaborator

I agree. It reads better and looks "simpler". 👍

@kevingimbel

kevingimbel May 19, 2017

Collaborator

I agree. It reads better and looks "simpler". 👍

@@ -191,7 +191,7 @@ func init() {
}
generators["domain.name"] = Generator{
- Name: "domain.tld",
+ Name: "domain.name",

This comment has been minimized.

@lucapette

lucapette May 19, 2017

Owner

the integration tests caught this :) One of the tests would randomly fail because two generators had the same name. Funny finding

@lucapette

lucapette May 19, 2017

Owner

the integration tests caught this :) One of the tests would randomly fail because two generators had the same name. Funny finding

@lucapette lucapette merged commit 34e7b13 into master May 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lucapette lucapette deleted the integration-tests branch May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment