Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

https instead of http; jiffy instead of mochijson; *_tests instead of *_test #1

Closed
wants to merge 11 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

llaisdy commented Aug 29, 2012

Dear Luca Spiller

I'm using your twerl and I've made a few changes so I thought I'd send a pull request.

  1. Twitter wouldn't accept requests without https;
  2. I've switched to using jiffy instead of mochijson2. Mainly as I'm a bit more familiar with it (haven't seen mochijson2 about much recently);
  3. The tests in test/*_test.erl didn't seem to be picked up by eunit, and the erlang docs say use _tests.erl (see below). I renamed the modules and the number of tests passing went up by about 20.

Thanks very much for your work on twerl!

Best wishes

Ivan

p.s. This is my first pull request, so many apologies for verbosity and any breaches of etiquette.

http://www.erlang.org/doc/apps/eunit/chapter.html

** Putting tests in separate modules

If you want to separate your test code from your normal code (at least for testing the exported functions), you can simply write the test functions in a module named m_tests (note: not m_test), if your module is named m. Then, whenever you ask EUnit to test the module m, it will also look for the module m_tests and run those tests as well.

Owner

lucaspiller commented Aug 29, 2012

Awesome! That looks great, thanks for your work. I'll take a proper
look this evening and merge it in.

Out of curiosity what project are you using it for?

Contributor

llaisdy commented Aug 29, 2012

Dear Luca

Thanks for your email. I hope the changes are acceptable.

I'm writing a twitter client that listens to the twitter stream and does
things like store or email out results. It's an internal project.

Your readme mentions a goal:

A client manager which allows you to change the search queries
without losing any data (WIP).

I'll need to have different searches with different owners, so I might
be writing something along these lines. Do/did you have specific plans?

Best wishes

Ivan

On 29/08/2012 12:45, Luca Spiller wrote:

Awesome! That looks great, thanks for your work. I'll take a proper
look this evening and merge it in.

Out of curiosity what project are you using it for?

Ivan A. Uemlianin PhD
Llaisdy
Speech Technology Research and Development

                 ivan@llaisdy.com
                  www.llaisdy.com
                      llaisdy.wordpress.com
           github.com/llaisdy
                  www.linkedin.com/in/ivanuemlianin

           "hilaritas excessum habere nequit"
              (Spinoza, Ethica, IV, XLII)

llaisdy and others added some commits Aug 29, 2012

Update rebar.config
rebar fails with

{version_mismatch,{".../deps/jiffy/src/jiffy.app.src",
                   {expected,"0.5.*"},
                   {has,"0.6.1"}}}.
Owner

lucaspiller commented May 5, 2013

Hey, sorry for not getting around to this sooner. I've been busy doing other stuff, but I've come back to working on this now.

I've cherry-picked a few of your changes:

  • using Jiffy
  • Handling <<"\r\n">>

I've changed a lot on the project (I completely forgot about this, I did the SSL myself too :P), so that's all that is really relavent now. Thanks!

@lucaspiller lucaspiller closed this May 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment