Make the build reproducible #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucc
requested changes
Oct 28, 2019
Whilst working on the Reproducible Builds effort [0] we noticed that khard could not be built reproducibly. This is because it includes the absolute build directory in the documentation via the SPEC_FILE attribute. This commit calculates this value dynamically instead. This was originally filed in Debian as #943471 [1]. [0] https://reproducible-builds.org/ [1] https://bugs.debian.org/943471
lamby
force-pushed
the
943471-khard-please-make-the-build-reproducible
branch
from
35ba4a3
to
2290509
Compare
|
Thanks for the quick review; pushed updated commit.. |
lucc
approved these changes
Oct 28, 2019
|
Thanks for you help @lamby ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort we noticed that khard could not be built reproducibly.
This is because it includes the absolute build directory in the documentation via the
SPEC_FILEattribute. This commit calculates this value dynamically instead.(This was originally filed in Debian as #943471.)