From c89167c67835eb28c60141f0a7952adf68338c41 Mon Sep 17 00:00:00 2001 From: Zac Spitzer Date: Sat, 16 Jul 2022 09:15:45 +0200 Subject: [PATCH] extra tests, only run ftp tests --- .github/workflows/main.yml | 4 ++-- test/tags/FTP.cfc | 6 +++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 3a78e70122f..65b5806b25f 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -198,10 +198,10 @@ jobs: run: | if [ "${DO_DEPLOY}" == "true" ]; then echo "------- Maven Deploy on ${{ github.event_name }} -------"; - mvn -B -e -f loader/pom.xml clean deploy --settings travis-settings.xml -DtestJavaVersionExec="${{ env.LUCEE_TEST_JAVA_EXEC }}"; + mvn -B -e -f loader/pom.xml clean deploy --settings travis-settings.xml -DtestJavaVersionExec="${{ env.LUCEE_TEST_JAVA_EXEC }}"; -DtestFilter="ftp" else echo "------- Maven Install on ${{ github.event_name }} ---------"; - mvn -B -e -f loader/pom.xml clean install -DtestJavaVersionExec="${{ env.LUCEE_TEST_JAVA_EXEC }}" + mvn -B -e -f loader/pom.xml clean install -DtestJavaVersionExec="${{ env.LUCEE_TEST_JAVA_EXEC }}" -DtestFilter="ftp" fi - name: Publish Test Results uses: EnricoMi/publish-unit-test-result-action@v1 diff --git a/test/tags/FTP.cfc b/test/tags/FTP.cfc index 0617524940d..4ef108a71d4 100644 --- a/test/tags/FTP.cfc +++ b/test/tags/FTP.cfc @@ -124,7 +124,11 @@ component extends="org.lucee.cfml.test.LuceeTestCase" labels="ftp,sftp" { // we add again a file and directory to be sure we can delete a folder with content ftp action="createdir" directory=subdir connection = "conn"; - ftp action="putFile" localfile=getCurrentTemplatePath() remoteFile=subfile connection= "conn"; + ftp action="putFile" localfile=getCurrentTemplatePath() remoteFile=subfile connection="conn"; + // LDEV-3528 transferMode=“binary” causes "Connection is not open" error + ftp action="putFile" localfile=getCurrentTemplatePath() remoteFile=subfile connection="conn" transferMode="ASCII"; + ftp action="putFile" localfile=getCurrentTemplatePath() remoteFile=subfile connection="conn" transferMode="auto"; // default + ftp action="putFile" localfile=getCurrentTemplatePath() remoteFile=subfile connection="conn" transferMode="binary"; }