Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimiss pointer wp496 privacy #1

Conversation

Projects
None yet
2 participants
@garrett-eclipse
Copy link
Contributor

commented Jan 14, 2019

Hi Luciano,

While looking at #45529 your plugin was mentioned so wanted to provide a PR of my findings with the issue.

It seems the remove_action for pointer_wp496_privacy needs to be called from a admin_enqueue_scripts action with priority of 11. I tried priority 10 but with remove actions it's always best to increment your call by 1.

I've tested my branch locally and this is working nicely, give it a try and let me know if you've like any changes.

I also added this to update your 'Why this plugin?' section;

    • The remove_action for pointer_wp496_privacy needed to be called from the admin_enqueue_scripts action with a priority of 11.
      *I can remove this part of the PR if you'd like.

All the best,
Cheers

@luciano-croce
Copy link
Owner

left a comment

Thanks Brother!

@luciano-croce
Copy link
Owner

left a comment

Thanks Brother!

@luciano-croce luciano-croce merged commit 36ade21 into luciano-croce:master Jan 14, 2019

@garrett-eclipse garrett-eclipse deleted the garrett-eclipse:dimiss-pointer_wp496_privacy branch Jan 14, 2019

@garrett-eclipse

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

No worries @luciano-croce thanks for the merge. Glad it works nicely for you

@luciano-croce luciano-croce added the bug label Jan 14, 2019

Repository owner locked as resolved and limited conversation to collaborators Jan 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.