Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing manifest retry timeout #717

Open
paulcsmith opened this issue Mar 4, 2019 · 0 comments
Open

Allow customizing manifest retry timeout #717

paulcsmith opened this issue Mar 4, 2019 · 0 comments
Milestone

Comments

@paulcsmith
Copy link
Member

https://gitter.im/luckyframework/Lobby?at=5c7d7df053efa91203b20816

@paulcsmith paulcsmith added this to the Lucky next milestone Jun 13, 2019
paulcsmith added a commit that referenced this issue Jun 18, 2019
Closes #717

Note the ENV vars must be available at compile time. This means setting
them in a .env file will not work. Instead add them to your command in
Procfile.dev.

    web: ASSET_HELPER_TIMEOUT_IN_SECONDS=15 lucky watch
paulcsmith added a commit that referenced this issue Jun 18, 2019
Closes #717

It also only looked for a manifest but not a particular file. The
problem with that is that you may have an old manifest that is in the
process of being updated. That means Lucky incorrectly thinks the asset
doesn't exist, when in reality the asset compilation process just hasn't
finished and therefore hasn't updated the manifest.

Instead we look for particular assets. So even if the manifest exists it
will retry until the new asset is there or it times out

---

Note the ENV vars must be available at compile time. This means setting
them in a .env file will not work. Instead add them to your command in
Procfile.dev.

    web: ASSET_HELPER_TIMEOUT_IN_SECONDS=15 lucky watch
paulcsmith added a commit that referenced this issue Jun 18, 2019
Closes #717

It also only looked for a manifest but not a particular file. The
problem with that is that you may have an old manifest that is in the
process of being updated. That means Lucky incorrectly thinks the asset
doesn't exist, when in reality the asset compilation process just hasn't
finished and therefore hasn't updated the manifest.

Instead we look for particular assets. So even if the manifest exists it
will retry until the new asset is there or it times out

---

Note the ENV vars must be available at compile time. This means setting
them in a .env file will not work. Instead add them to your command in
Procfile.dev.

    web: ASSET_HELPER_TIMEOUT_IN_SECONDS=15 lucky watch
paulcsmith added a commit that referenced this issue Jun 18, 2019
Closes #717

It also only looked for a manifest but not a particular file. The
problem with that is that you may have an old manifest that is in the
process of being updated. That means Lucky incorrectly thinks the asset
doesn't exist, when in reality the asset compilation process just hasn't
finished and therefore hasn't updated the manifest.

Instead we look for particular assets. So even if the manifest exists it
will retry until the new asset is there or it times out

---

Note the ENV vars must be available at compile time. This means setting
them in a .env file will not work. Instead add them to your command in
Procfile.dev.

    web: ASSET_HELPER_TIMEOUT_IN_SECONDS=15 lucky watch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant