Skip to content
Permalink
master

Commits on Dec 31, 2020

  1. Upgrade to Laravel Mix 6 (#592)

    * Upgrade to Laravel Mix 6
    
    * Move up public namespace, then remove namespace from Laravel Mix js asset definition.
    stephendolan committed Dec 31, 2020
  2. Pass --error-trace to precompiling tasks (#596)

    matthewmcgarvey committed Dec 31, 2020

Commits on Dec 28, 2020

Commits on Dec 26, 2020

  1. Raise log level on DB::Log to :info (#589)

    This will prevent Crystal DB from flooding the console with "Executing
    Query" messages for every query executed.
    robacarp committed Dec 26, 2020

Commits on Dec 17, 2020

  1. Bump actions/setup-node from v2.1.3 to v2.1.4 (#591)

    Bumps [actions/setup-node](https://github.com/actions/setup-node) from v2.1.3 to v2.1.4.
    - [Release notes](https://github.com/actions/setup-node/releases)
    - [Commits](actions/setup-node@v2.1.3...c46424e)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot committed Dec 17, 2020

Commits on Dec 15, 2020

  1. Release 0.25.0 (#588)

    * Release 0.25.0
    
    * trying to force GH Actions to run
    
    * Update version to actual releases
    
    * bump authentic
    jwoertink committed Dec 15, 2020

Commits on Dec 14, 2020

  1. Add `task` env detection (#576)

    * add LUCKY_TASK env var to web_app_skeleton
    
    * Add `task?` helper to env config
    
    * format config/env.cr of web_app_skeleton
    
    Co-authored-by: KCErb <kc@kcerb.com>
    KCErb and KCErb committed Dec 14, 2020

Commits on Dec 12, 2020

  1. Bump actions/setup-node from v1 to v2.1.3 (#587)

    Bumps [actions/setup-node](https://github.com/actions/setup-node) from v1 to v2.1.3.
    - [Release notes](https://github.com/actions/setup-node/releases)
    - [Commits](actions/setup-node@v1...27082ce)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot committed Dec 12, 2020

Commits on Nov 29, 2020

  1. Rename template seed tasks to fit in with the rest of the stock tasks (

    …#584)
    
    * db.create_required_seeds -> db.seed.required_data
    
    The rest of the tasks in `lucky -h` are formatted using [reverse domain name notation](https://en.wikipedia.org/wiki/Reverse_domain_name_notation):
    
    db.schema.dump / db.schema.restore
    db.migrate / db.migrate.one
    gen.action.api / gen.action.browser
    
    This changes the default generated task `db.create_required_seeds` to `db.seed.required_data` to match the existing notation.
    
    * db.create_sample_seeds -> db.seed.sample_data
    
    The rest of the tasks in `lucky -h` are formatted using [reverse domain name notation](https://en.wikipedia.org/wiki/Reverse_domain_name_notation):
    
    db.schema.dump / db.schema.restore
    db.migrate / db.migrate.one
    gen.action.api / gen.action.browser
    
    This changes the default generated task `db.create_sample_seeds` to `db.seed.sample_data` to match the existing notation.
    
    * Update seed tasks in setup.ecr
    robacarp committed Nov 29, 2020

Commits on Nov 6, 2020

  1. lucky dev: When Ctrl+C is pressed, wait for the child process to hand…

    …le the signal and finish - rather than us immediately exiting and leaving it to log shutting down messages from the background (#572)
    
    * lucky dev: When Ctrl+C is pressed, wait for the child process to handle the signal and finish - rather than us immediately exiting and leaving it to log shutting down messages from the background
    
    Resolves #570. I've just used the approach I suggested there.
    
    I wasn't sure how/if to write a spec for this, so I haven't. Is that acceptable?
    
    To test it manually, I ran this from my app directory before and after the change to verify the behaviour:
    
    ```bash
    $ crystal run ~/Projects/lucky_cli/src/lucky.cr -- dev
    ```
    
    * Update src/lucky_cli/process_runner.cr
    
    * oops. formatted
    
    Co-authored-by: Jeremy Woertink <jeremywoertink@gmail.com>
    ZimbiX and jwoertink committed Nov 6, 2020
  2. Disable 'Compiling' spinner on CI to avoid clogging logs (#573)

    Resolves #560.
    
    The Spinner class is complex, so I didn't really want to add to the complexity - especially with no tests. I considered implementing a `NullSpinner`, but the spinner interface is not super simple; it felt simpler to use the existing spinner class conditionally from its one usage in `BuildAndRunTask`.
    
    It is curious that the spinner supports several unused features.
    
    Co-authored-by: Jeremy Woertink <jeremywoertink@gmail.com>
    ZimbiX and jwoertink committed Nov 6, 2020
  3. Fix init.custom task name in banner text (#571)

    * Fix init.custom task name in banner text
    
    Running `lucky custom.init` does not work
    
    * Rename CustomInit -> InitCustom - to reflect task name
    
    Co-authored-by: Jeremy Woertink <jeremywoertink@gmail.com>
    ZimbiX and jwoertink committed Nov 6, 2020
  4. Using Avram master to update all generated Operations to use the new …

    …structure (#575)
    
    * Using Avram master to update all generated Operations to use the new structure
    
    * recent changes required being on ameba master until next release
    
    * trying to get these specs fixed
    
    * We can't always check that the DB is dropped because that one spec that generates a project, but never actually migrates
    
    * need to skip the entire block
    
    * formatted
    jwoertink committed Nov 6, 2020

Commits on Nov 5, 2020

  1. Adding a cleanup method for integration specs to ensure the generated…

    … DB is also dropped as well as removing all generated project files. Fixes #578 (#579)
    jwoertink committed Nov 5, 2020

Commits on Oct 27, 2020

  1. Add semicolon and missing newline (#568)

    paulcsmith committed Oct 27, 2020

Commits on Oct 25, 2020

Commits on Oct 23, 2020

  1. Update generated app development package.json dependencies (#553)

    Before I get into details, I've been running these dependencies in [Lucky Jumpstart](https://github.com/stephendolan/lucky_jumpstart) Lucky apps without issue for quite a while now. I also want to re-emphasize that this only bumps **development** dependencies, since all production dependencies are up to date.
    
    The long term discussion about how and if we keep this up to date is [here](luckyframework/lucky#1261).
    
    Below, I'll provide a rundown of the version changes made, as well as a TL;DR list of breaking changes that were noted.
    
    This PR tackles:
    
    - Alphabetizing the `dependencies:` section, since that seems to be the intention
    - Bumping `compression-webpack-plugin` from `^3.0.0` to `^6.0.1` ([Changelog here](https://github.com/webpack-contrib/compression-webpack-plugin/blob/master/CHANGELOG.md))
      - 3 -> 4 breaking changes
        - the cache is true by default for webpack@4
        - the cache option is ignored in webpack 5. Please use https://webpack.js.org/configuration/other-options/#cache.
        - minimum supported Node.js version is 10.13
      - 4 -> 5 breaking changes
        - default value of the filename option is '[path].gz'
        - use processAssets hook for webpack@5 compatibility, it can create incompatibility with plugins that do not support webpack@5, please open an issue in their repositories
      - 5 -> 6 breaking changes
        - default value of the filename option was changed to "[path][base].gz"
        - removed the [dir] placeholder, please use the [path] placeholder
        - the Function type of the filename option should return value with placeholders, please see an example: https://github.com/webpack-contrib/compression-webpack-plugin#function-1
    - Bumping `laravel-mix` from `^4.0.0` to `^5.0.5` ([Changelog here](https://github.com/JeffreyWay/laravel-mix/releases))
      - 4 -> 5 breaking changes
        - Use `sass-loader` `8`
    - Bumping `resolve-url-loader` from `2.3.1` to `^3.1.1` ([Changelog here](https://github.com/bholloway/resolve-url-loader/releases))
      - 2 -> 3 breaking changes
        - Multiple options changed or deprecated.
        - Removed file search "magic" in favour of join option.
        - Errors always fail and are no longer swallowed.
        - Processing absolute asset paths requires root option to be set.
    - Bumping `sass` from `1.17.1` to `^1.26.10` ([Changelog here](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md))
    - Bumping `sass-loader` from `^7.3.1` to `^10.0.2` ([Changelog here](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md))
      - 7 -> 8 breaking changes
        - minimum required webpack version is 4.36.0
        - minimum required node.js version is 8.9.0
        - move all sass (includePaths, importer, functions, outputStyle) options to the sassOptions option. The functions option can't be used as Function, you should use sassOption as Function to achieve this.
        - the data option was renamed to the prependData option
        - default value of the sourceMap option depends on the devtool value (eval/false values don't enable source map generation)
      - 8 -> 9 breaking changes
        - minimum supported Nodejs version is 10.13
        - prefer sass (dart-sass) by default, it is strongly recommended to migrate on sass (dart-sass)
        - the prependData option was removed in favor the additionalData option, see docs
        - when the sourceMap is true, sassOptions.sourceMap, sassOptions.sourceMapContents, sassOptions.sourceMapEmbed, sassOptions.sourceMapRoot and sassOptions.omitSourceMapUrl will be ignored.
      - 9 -> 10 breaking changes
        - loader generates absolute sources in source maps, also avoids modifying sass source maps if the sourceMap option is false
    - Bumping `vue-template-compiler` from `^2.5.22` to `^2.6.12` ([Changelog here](https://github.com/vuejs/vue/tree/dev/packages/vue-template-compiler#readme))
    stephendolan committed Oct 23, 2020
  2. Rename with_defaults to tag_defaults (#552)

    This PR aims to close #548
    
    This PR tackles:
    - Renaming with_defaults in `browser_app_skeleton/src/components/shared/field.cr` to the new `tag_defaults` signature implemented [here](luckyframework/lucky#1262)
    - Renaming the yielded block from `input_builder` to `tag_builder` to keep all Lucky-generated docs/code/comments consistent and (hopefully) better convey meaning
    stephendolan committed Oct 23, 2020
  3. Install browser in CI instead of Chromedriver (#565)

    Let webdrivers.cr install chromedriver for appropriate browser.
    
    Closes #564 
    
    Tested and verified here: https://github.com/stephendolan/lucky_jumpstart/runs/1298680502
    stephendolan committed Oct 23, 2020

Commits on Oct 21, 2020

  1. Generate default GitHub Actions config (#559)

    skojin committed Oct 21, 2020
  2. Task cli arg update (#557)

    * Allow for setting a custom IO on tasks. This can be used when testing.
    
    * removed deprecated banner macro since it's been deprecated for like 10 releases now
    
    * Cleanup help printing code to utilize the output property since that was only used for testing anyway
    
    * Getting in the habit of using official deprecation annotations
    
    * Adds an example option for args and positional_args to help clarify the error messages better.
    
    * ran ameba, formatter, and fixing specs not calling the deprecated method correctly
    
    * Actually fixing the deprecation warning
    jwoertink committed Oct 21, 2020

Commits on Sep 25, 2020

  1. Default to printing emails to logs in development (#555)

    This PR aims to make debugging emails a bit more straightforward for more Lucky users. I remember being quite confused the first time I tried to send an email in dev, and ended up enabling SendGrid since I couldn't determine how to show the email content.
    
    Since then, I've dug into the Carbon source and found the nifty `print_emails` option when initializing a `Carbon::DevAdapter`! I think it'd be handy to turn that on by default in dev, especially since if it's too noisy turning the flag off is pretty straightforward.
    stephendolan committed Sep 25, 2020

Commits on Sep 9, 2020

  1. Revert DATABASE_URL rename to DB_URL (#551)

    This PR aims to make default-generated apps work with most DB services again
    by renaming DB_URL back to DATABASE_URL.
    stephendolan committed Sep 9, 2020

Commits on Sep 5, 2020

  1. Release 0.24.0 (#550)

    * Release 0.24.0
    
    * needed to bump authentic so the lucky versions match up
    jwoertink committed Sep 5, 2020

Commits on Sep 4, 2020

  1. Updates/crystal 0.35.1 (#549)

    * Updated the version of crystal generated apps use
    
    * Found this mistake while looking for other instances of crystal version.
    jwoertink committed Sep 4, 2020

Commits on Sep 3, 2020

  1. Updates for latest Lucky (#547)

    * Banged head on desk a few times
    * Things work
    * Updating the Avram config to use Credentials
    * Renaming m -> mount
    jwoertink committed Sep 3, 2020

Commits on Aug 31, 2020

  1. Renamed AppClient to ApiClient. (#534)

    * Renamed AppClient to ApiClient. Added BrowserClient for testing. Fixes #492
    
    * I think this should probably only be generated if you're generating a browser app.
    
    * Removing this file for now until we can figure out sessions and POST params and stuff
    jwoertink committed Aug 31, 2020
  2. Shards overrides (#545)

    * Adding in structure to allow us to override shards for testing
    
    * Actually, the default for the override should be commented out. This way the specs should still pass as is.
    
    * due to a shards bug, we have to set the default to something.
    
    * Attempting to some debug because I have no clue how this is supposed to work
    
    * The last one didn't work, trying this
    
    * Now that specs pass, I don't need this debug
    
    * A little cleanup. Also trying out this suggestion for the override to not be set by default
    
    * newline cinema
    jwoertink committed Aug 31, 2020
  3. Added a catch for reserved project names (#543)

    * Added a catch for reserved project names so someone doesn't generate an app called 'app'. Fixes #540
    
    * Easier to read logic, and a few less lines
    jwoertink committed Aug 31, 2020

Commits on Aug 27, 2020

  1. Add Ameba checks to CI and fix non-compliant code (#538)

    * Add Ameba checks to CI and fix non-compliant code
    
    * Revert anonymous argument now that Ameba permits descriptive underscored variables
    
    * Bump Ameba GitHub action to newest version
    
    * Since we already have Ameba in dev dependencies, just use that
    
    * Revert the naming change to the check step in GitHub Actions
    stephendolan committed Aug 27, 2020

Commits on Aug 10, 2020

  1. Update docs

    paulcsmith committed Aug 10, 2020
    2
  2. added disable_cookies as default for api actions (#535)

    * added disable_cookies as default for api actions
    
    * added comment
    
    * Update api_action.cr.ecr
    confact committed Aug 10, 2020

Commits on Jul 7, 2020

  1. bump version

    jwoertink committed Jul 7, 2020
  2. Update all instances of mount to use m. Fixes #529 (#531)

    jwoertink committed Jul 7, 2020
Older
You can’t perform that action at this time.