New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objective-C with precompiled framework #6

Closed
aonez opened this Issue Aug 17, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@aonez

aonez commented Aug 17, 2017

I've added the release framework to my project, included the import as this:

@import ThemeKit;

Saw on #5 that you've mentioned macOSThemeKit but this does not appear to exists. Anyway the code compiles, so ThemeKit it is.

Then just included the sample code of the dark theme, but the project fails to load due to some Swift libraries not found, like libswiftAppKit.dylib.

Importing the ThemeKit project in my project and compiling it works, since then my app included all the Swift related frameworks. Just pointing it so Objective-c projects that do not yet use Swift code should not use the release framework, or must check all the Swift related frameworks will be added as well.

@aonez

This comment has been minimized.

Show comment
Hide comment
@aonez

aonez Aug 17, 2017

Looks cool though, nice framework 👍

untitled 5

aonez commented Aug 17, 2017

Looks cool though, nice framework 👍

untitled 5

nfgrilo added a commit that referenced this issue Oct 13, 2017

@nfgrilo

This comment has been minimized.

Show comment
Hide comment
@nfgrilo

nfgrilo Oct 13, 2017

Collaborator

Thank you again for your input!

In fact, @import macOSThemeKit is only for the case where the lib is pulled from CocoaPods (name was taken); for any other case @import ThemeKit is the way to go! Anyway, I took the chance to mention this information you just provided on the README file.

Thanks!

Collaborator

nfgrilo commented Oct 13, 2017

Thank you again for your input!

In fact, @import macOSThemeKit is only for the case where the lib is pulled from CocoaPods (name was taken); for any other case @import ThemeKit is the way to go! Anyway, I took the chance to mention this information you just provided on the README file.

Thanks!

@nfgrilo nfgrilo closed this Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment