luckysori
Follow
Pinned
1,464 contributions in the last year
Contribution activity
March 2023
Created 85 commits in 1 repository
Created a pull request in get10101/10101 that received 10 comments
Do not remake connection to WS unnecessarily
I had tested the example and then failed to copy the code used in the example for the app
+178
−102
•
10
comments
Opened 15 other pull requests in 1 repository
get10101/10101
14
merged
1
closed
-
Start
coordinatorandmakerafter Electrum server is ready injustfile -
Add endpoint to get
coordinatorDLC channels - Fixing bugs appearing during environment setup
- feat(justfile): Delete app data directory for Linux
- Reply to DLC open/close offers immediately (and only once)
- Reconnect to orderbook WebSocket if app stream ends
- Improve upon close-position PR
- Fix LN wallet double balance
-
Remove unused
Cargo.lockfiles - Add Clippy lint workspace configuration
- Verify open-close-open DLC channel behaviour
- Add APIs to perform DLC collaborative settlement
-
Minimise need to depend on
rust-dlcin leaf crates -
Update to latest
rust-dlc -
Make
ln-dlc-nodetests a bit more resilient
Reviewed 41 pull requests in 1 repository
get10101/10101
25 pull requests
- Display the price from order book in the UI
- Feat/wallet history
- fix: on restart a node is not registered anymore
- fix: should stop flutter from upgrading
- fix: Compute payout is greater than total collateral
- chore: listen on broadcast address
- chore: Use same price for pnl and collab settlement
- Add a refresh indicator so that we can update the wallet manually
- Harmonize order state handling
- fix: Mount correct paths to volumes
- feat: in memory position that can be closed in UI
- Fixing bugs appearing during environment setup
- Do not remake connection to WS unnecessarily
- Bunch of small fixes spotted whilst coming up to speed with the project
- Reply to DLC open/close offers immediately (and only once)
- make things more configurable so that they run on our testnet vm
- Align clippy flags for all builds
- chore: rename test
- Improve upon close-position PR
- refactor: Start the lifecycle of the order after submission to orderbook
- feat: Close position
- chore: minor clean-ups
- feat: orderbook client
- feat: add order matching function
- feat: Initiate the dlc channel setup from the coordinator
- Some pull request reviews not shown.
Created an issue in get10101/10101 that received 3 comments
Use payout calculation when calculating close position trade amount in TX history
At the moment we use the margin calculation, which is incorrect because it doesn't include the PNL. See: #307 (comment).
3
comments
Opened 10 other issues in 1 repository
get10101/10101
7
open
3
closed
- App received all orders from orderbook even though it already had some orders
- Persist history of inbound and outbound payments
-
Cannot always pay funding invoice due to
no_route - App is unable to accept DLC channel offer with certain parameters
-
coordinatorandmakerprocesses crash due to Electrum error -
Cannot always pay invoice via faucet due to
insufficient-balance - App database file location is shared between all networks
- Attempt to accept DLC only when offer is received
- Orderbook client cannot reconnect to orderbook WS
- Run Clippy CI job for each crate separately