prov-n internationalized string incorrectly serialized #133

Closed
lucmoreau opened this Issue Jul 13, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@lucmoreau
Owner

lucmoreau commented Jul 13, 2015

prov-n internationalized strings are currently serialized as

"un lieu"@fr %% prov:InternationalizedString

instead of

"un lieu"@fr

The type prov:InternationalizedString is the type for such strings in the xml serialization. It is also how
the ProvToolbox encodes the types of such strings internally. It should not be exposed in the prov-n representation.

I don't know how this bug this affects the json serialization.

@trungdong

This comment has been minimized.

Show comment
Hide comment
@trungdong

trungdong Jul 13, 2015

Contributor

I don't think it have any impact on prov-json as I'm checking the Java type of the value (whether it is a LangString) before encoding it as an international string.

Contributor

trungdong commented Jul 13, 2015

I don't think it have any impact on prov-json as I'm checking the Java type of the value (whether it is a LangString) before encoding it as an international string.

@lucmoreau

This comment has been minimized.

Show comment
Hide comment
@lucmoreau

lucmoreau Jul 13, 2015

Owner

There is probably a change required to the prov-json spec to explain how to serialise internationalized strings.

Owner

lucmoreau commented Jul 13, 2015

There is probably a change required to the prov-json spec to explain how to serialise internationalized strings.

@trungdong

This comment has been minimized.

Show comment
Hide comment
@trungdong

trungdong Jul 13, 2015

Contributor

PROV-JSON says:

if the xsd:string value has a language tag, the literal must be represented in a JSON object as specified above, the language tag in the lang property and the type property omitted.

It looks like I should remove those prov:InternationalString added in the JSON outputs.

Contributor

trungdong commented Jul 13, 2015

PROV-JSON says:

if the xsd:string value has a language tag, the literal must be represented in a JSON object as specified above, the language tag in the lang property and the type property omitted.

It looks like I should remove those prov:InternationalString added in the JSON outputs.

@lucmoreau

This comment has been minimized.

Show comment
Hide comment
@lucmoreau

lucmoreau Jul 13, 2015

Owner

I think that an xsd:string cannot have a language tag since it is a XML simple type.

Owner

lucmoreau commented Jul 13, 2015

I think that an xsd:string cannot have a language tag since it is a XML simple type.

@lucmoreau

This comment has been minimized.

Show comment
Hide comment
@lucmoreau

lucmoreau Jul 23, 2015

Owner

Original issue is now addressed in development branch. Prov-json issue is outstanding.

Owner

lucmoreau commented Jul 23, 2015

Original issue is now addressed in development branch. Prov-json issue is outstanding.

@lucmoreau lucmoreau added prov-json and removed bug prov-n labels Jul 23, 2015

lucmoreau added a commit that referenced this issue Aug 11, 2015

Merge pull request #143 from trungdong/dev-json
Removed "prov:InternationalizedString" from JSON output (#133)

@lucmoreau lucmoreau closed this in ba301a6 Sep 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment