Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to control figure size in plots plus fixes #56

Merged
merged 5 commits into from
Apr 20, 2023
Merged

Add option to control figure size in plots plus fixes #56

merged 5 commits into from
Apr 20, 2023

Conversation

flokno
Copy link
Contributor

@flokno flokno commented Jan 25, 2023

  • Add option to modify the default figure size of figsize=(8, 8) in the plot functions from outputs
  • Add version stamp to setup.cfg so that pip can correctly version effmass

@flokno
Copy link
Contributor Author

flokno commented Jan 25, 2023

  • add fix when aims is used and output file is not called calculation.out

@flokno flokno marked this pull request as draft January 25, 2023 14:35
@flokno
Copy link
Contributor Author

flokno commented Jan 25, 2023

(marked as draft until I tested everything I need)

@flokno flokno marked this pull request as ready for review January 27, 2023 12:33
@flokno
Copy link
Contributor Author

flokno commented Jan 27, 2023 •
edited
Loading

Should be fine now. Overall I fixed some bugs and made some slight adjustments for my own small cli script.

@lucydot let me know if you disagree with anything.

@flokno flokno changed the title Add option to control figure size in plots Add option to control figure size in plots plus fixes Jan 28, 2023
@lucydot
Copy link
Owner

lucydot commented Apr 20, 2023

Sorry for super late reply @flokno and ⭐ thank you ⭐ for your contribution!

@lucydot lucydot merged commit 2cde44a into lucydot:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flokno @lucydot