Permalink
Commits on Aug 19, 2018
  1. Correct scrollUp behavior

    kurthindenburg authored and ivan committed Jul 1, 2017
    CSI S escape sequence (SU, scroll up) ignored if number of lines to
    scroll bigger than scrollable lines
    
    REVIEW: 130133
    BUG: 379318
Commits on Feb 1, 2018
  1. Fix annoying behavior on tab close: don't focus the most-recently-use…

    ivan committed Dec 27, 2017
    …d tab; focus the tab to the right instead
Commits on Dec 5, 2017
  1. Remove delay in dragging tabs

    kurthindenburg authored and ivan committed Aug 29, 2017
    When one tries to drag a tab there is a lot of lag at the start of the
    drag gesture. As a result the tab is likely to be trailing the mouse
    pointer by inches so that figuring out where the tab will end up is
    quite confusing.
    
    BUG: 371939
    Differential Revision: https://phabricator.kde.org/D7451
    
    (cherry picked from commit 14bf3b4)
Commits on Dec 3, 2017
Commits on Dec 6, 2016
  1. SVN_SILENT made messages (.desktop file) - always resolve ours

    l10n daemon script
    l10n daemon script committed Dec 6, 2016
    In case of conflict in i18n, keep the version of the branch "ours"
    To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
Commits on Nov 29, 2016
Commits on Nov 24, 2016
  1. set default TERM=xterm-256color

    kurthindenburg committed Nov 24, 2016
    Change TERM=xterm to xterm-256color
    
    CCBUG: 371919
    BUG: 212145
    (cherry picked from commit 2671800)
  2. sync value order with how 16.08 writes them

    apachelogger authored and kurthindenburg committed Nov 21, 2016
    makes it easier to spot difference when copying a changed theme moving
    forward
    
    REVIEW: 129369
    (cherry picked from commit 9470fd0)
  3. Fix Save Output as -> HTML

    kurthindenburg committed Nov 20, 2016
    I don't see how this ever worked - not the best solution but it works
    now.
    
    (cherry picked from commit 1ba498b)
  4. Only use foreground process info if valid

    sandsmark authored and kurthindenburg committed Nov 20, 2016
    getProcessInfo() returned _foregroundProcessInfo without checking the
    return value of updateForegroundProcessInfo() indicating whether
    _foregroundProcessInfo was non-existent or invalid.
    
    I think this might be the solution to a bunch of recent crash bugs,
    but not closing them as I can't test.
    
    Also skipping RB because it is a simple patch and RB is down from here.
    
    CCBUG: 372401
    CCBUG: 372620
    CCBUG: 372619
    CCBUG: 372593
    (cherry picked from commit 40b1f0e)
  5. Don't crash/assert on trying to load session with invalid ID

    sandsmark authored and kurthindenburg committed Nov 20, 2016
    Failing to find a ID should not be a fatal assert, the ViewManager
    handles it properly.
    
    BUG: 372173
    (cherry picked from commit c5ccfc2)
  6. Fix crash with combining characters after several cursorRight() calls

    sandsmark authored and kurthindenburg committed Nov 20, 2016
    cursorRight() does not resize the _screenLines vector, leading to an
    assert in QVector when trying to look up the _cuX which is bigger than
    the amount of characters in the current line.
    
    BUG: 372530
    (cherry picked from commit 80b9e07)
  7. Add COLORTERM=truecolor to the environment

    kurthindenburg committed Nov 19, 2016
    FEATURE: 371919
    (cherry picked from commit 8c7f165)
Commits on Nov 15, 2016
Commits on Nov 10, 2016
  1. Breeze color scheme uses better contrasting color for "black" color v…

    apachelogger committed Nov 10, 2016
    …alue
    
    The previous set of blueish colors offered fairly bad contrast with the
    charcoal grey background when using the "black" contrast value. To give
    a more uniform experience the default "black" color is now charcoal grey
    with it's intense variant shifted into a light grey to complement the
    intense background, which is charcoal grey shifted into a more intense dark
    
    This should offer overall better contrast, in particular in htop.
    
    BUG: 371068
    REVIEW: 129368
    CHANGELOG: Breeze color scheme uses better contrasting color for "black" color value
Commits on Nov 9, 2016
  1. Silence ubsan warnings about invalid pointer casts

    sandsmark committed Nov 5, 2016
    REVIEW: 129343
  2. Add setting for using multiple instances

    sandsmark committed Nov 6, 2016
    Adds a setting for forcing the use of multiple instances instead of
    running all instances in the same process. This way all terminals don't
    go down when one instance crashes.
    
    REVIEW: 129345
  3. Fix randomization in color scheme

    sandsmark committed Nov 5, 2016
    Use the new std::random APIs in c++11 for generating random numbers,
    which is much safer and doesn't abuse qsrand().
    
    This also means we don't need to copy in the QUuid::createUuid() code
    anymore, which generated a warning in ubsan.
    
    REVIEW: 129342
  4. Correct handling %u when changing tab title via Rename Tab dialog

    kurthindenburg committed Nov 9, 2016
    Recent code changed how %u is handled (only when %u is required, poll
    /proc filesystem).  This correct an issue when %u is added/removed from
    the Rename Tab dialog.
Commits on Nov 7, 2016
  1. Change close activate view to Ctrl+Shift+X to avoid duplicate

    kurthindenburg committed Nov 7, 2016
    The key sequence 'Ctrl+Shift+S' is ambiguous. Use 'Configure Shortcuts'
    from the 'Settings' menu to solve the ambiguity. This shortcut was used
    repeated times.
    
    Now its changed to CTRL+SHIFT+X. For closing active tab in the konsole
    of the split screen, it uses CTRL+SHIFT+X
    
    Thanks to Aniketh Girish anikethgireesh gmail com
    
    REVIEW: 129305
    BUG: 354954
  2. Add info about shortcut for menubar and DnD options

    Burkhard Lück
    Burkhard Lück committed Nov 7, 2016
    options for DnD
    shortcut for menubar
    remove extra space
    REVIEW:129300
Commits on Nov 4, 2016
  1. Fix memory leak when building with a11y support

    sandsmark committed Nov 4, 2016
    QAccessible::updateAccessibility() expects a pointer, but doesn't take
    ownership of the argument and expects us to delete it after we've called
    it. So just allocate the object on the stack like other users of this
    API do.
    
    Found by ASAN.
Commits on Nov 3, 2016
Commits on Nov 1, 2016
  1. Pass receiver as 3rd arg in qt5-style-connect, to avoid crashes when …

    dfaure committed Nov 1, 2016
    …the receiver is deleted.
    
    Testcase: splitting (ctrl+shift+'(') and then ctrl+shift+O
    (didn't crash every time, but valgrind was clear)
    
    CCMAIL: martin.sandsmark@kde.org
Commits on Oct 24, 2016
  1. SVN_SILENT made messages (.desktop file) - always resolve ours

    l10n daemon script
    l10n daemon script committed Oct 24, 2016
    In case of conflict in i18n, keep the version of the branch "ours"
    To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
Commits on Oct 22, 2016
  1. Fix reparsing of command line arguments

    sandsmark committed Oct 18, 2016
    If a new Konsole instance is launched via DBus (e. g. single process
    mode), it re-used the QCommandLineParser each time, so each new instance
    would inherit all parsed options.
    
    Most noticeably is if you have konsole running, press Shift+F4 in
    Dolphin to launch a Konsole instance in the current folder (which leads
    Konsole to use a temporary profile), and then try to open a new konsole
    instance outside of that, it would open in the folder from Dolphin.
    
    REVIEW: 129217
  2. Adjust a UI string to make its meaning clearer

    lliehu committed Oct 22, 2016
    REVIEW: 129232
Commits on Oct 18, 2016
  1. Make the config of file filters and url filters separate

    sandsmark committed Sep 4, 2016
    REVIEW: 128828
    BUG: 368234
Commits on Oct 12, 2016
  1. Fix typo in CMakeLists.txt option

    tsdgeos committed Oct 12, 2016
    Make it match the expected ifdef value
    
    CCMAIL: kurt.hindenburg@gmail.com
Commits on Oct 9, 2016