Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links not working on comments #1779

Closed
jasonleekennedy opened this issue Nov 18, 2018 · 4 comments
Closed

Links not working on comments #1779

jasonleekennedy opened this issue Nov 18, 2018 · 4 comments

Comments

@jasonleekennedy
Copy link

I attempted to link to a youtube video that had some good advice for an issue noted by the original poster, but if I put the link in in a way that the site detects the link, it get 'eaten'.

Post here ->
https://ldjam.com/events/ludum-dare/43/$120986/yeah-guess-im-in

I ended up removing the https:// from the link and it worked.
Issue happens even when doing 'preview'.

@jasonleekennedy
Copy link
Author

i was looking through my old posts to see if I wrote anything worth reading before the next LD and found that the youtube link here was also gone:
https://ldjam.com/events/ludum-dare/40/spatium-calorem/post-mortem-spatium-calorem.

I tested using a link to something that wasn't youtube (http://12games12weeks.blogspot.com) and it worked fine.

@jasonleekennedy
Copy link
Author

notice someone else's post with the same issue, they stated they could see it... appears to be an issue with ABP and the embed.

  • Firefox with uBlock Origin - they show up
  • Chrome with Ad-block Plus - they don't show up
  • Chrome with ABP turned off - they show up.

@local-minimum
Copy link
Contributor

There are too many different pieces of embed code in various places of the repo, but from what I can tell it might be

https://github.com/ludumdare/ludumdare/blob/master/src/com/autoembed/smartdomains.js

That the ? conflicts with another embed code that splits links at ? to strip away arguments.

@mikekasprzak
Copy link
Member

Closing this. User was missing the "https:" in the link, which would have triggered embedding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants