Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix svg preload warning #1825

Merged
merged 1 commit into from Jun 2, 2019

Conversation

Projects
None yet
2 participants
@zwrawr
Copy link
Member

commented Jun 2, 2019

Both the server and dev environment produce this warning
Screenshot from 2019-06-02 23-31-09
This is fixed by adding as=fetch; crossorigin.
fetch is used because the svg's are added to the document via javascript fetch request.
I'm not 100% sure why the cross-origin is needed as they're both from ludumdare.org, but it complains if it's not there.

Closes #403 (which was already fixed)

@mikekasprzak mikekasprzak merged commit 516a2be into ludumdare:master Jun 2, 2019

@zwrawr zwrawr deleted the zwrawr:svg-preload branch Jun 2, 2019

@zwrawr zwrawr added the Lighthouse label Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.