Restructured split config and added datetime splitting #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jppgks
reviewed
Jun 14, 2022
There was a problem hiding this comment.
This is a great improvement and much cleaner compared to the existing code, thanks Travis!
2 comments:
- Assuming split_index can only be one of 3 values (0, 1 or 2), should we introduce an enum for it instead of working with integers?
- Suggestion, potentially out of scope here: add JSON schema for split
justinxzhao
reviewed
Jun 14, 2022
|
|
||
| @split_registry.register("fixed") | ||
| class FixedSplitter(Splitter): | ||
| def __init__(self, column: str = SPLIT, **kwargs): |
There was a problem hiding this comment.
At some point (perhaps in separate PR), what do you think about extending this to enable users to specify custom values for fixed splits?
For example, I can imagine users with an explicit split column, but the values in the column are like "TRAIN", "TEST" instead of 0, 1, and 2.
(default)
split:
type: fixed
column: custom_split_column
train_values: [0]
validation_values: [1]
test_values: [2](custom)
split:
type: fixed
column: custom_split_column
train_values: [train]
validation_values: [test]
test_values: [heldout]Related: #1823
There was a problem hiding this comment.
Yes, I think we should definitely do this. Can be in a follow-up PR right after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2129.