Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_repeatable_train_val_test_split to handle non-stratified split w/ no existing split #2237

Merged
merged 6 commits into from
Jul 6, 2022

Conversation

amholler
Copy link
Collaborator

@amholler amholler commented Jul 6, 2022

As titled. Tested using new unit test added and on experiments repo regression datasets with no existing split column.

Bonus change: Avoid AutoML crash on dataset containing column of all NaNs (kdd).

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Unit Test Results

       6 files  ±0         6 suites  ±0   2h 20m 40s ⏱️ - 6m 15s
2 914 tests ±0  2 868 ✔️ ±0    46 💤 ±0  0 ±0 
8 742 runs  ±0  8 600 ✔️ ±0  142 💤 ±0  0 ±0 

Results for commit 5ec5011. ± Comparison against base commit 27e0b9b.

♻️ This comment has been updated with latest results.

ludwig/utils/dataset_utils.py Outdated Show resolved Hide resolved
@justinxzhao
Copy link
Collaborator

Thanks!

@justinxzhao justinxzhao merged commit d121eeb into ludwig-ai:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants