Ensure no ghost ray instances are running in tests #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnavgarg1
added a commit
that referenced
this pull request
Oct 14, 2022
* Add test fixtures to prevent double initialization * contain dataframe utils test in ray test fixture * add fixture for training determinism test * fix typo in docstring
arnavgarg1
added a commit
that referenced
this pull request
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that tests that use a Ray backend and initialize Ray always call
ray.shutdown()so that there are no ghost ray instances running in subsequent tests. This causes a problem for downstream tests that want to either initialize ray manually or through a test fixture, because they try to re-initialize ray. If one decides to add theignore_reinit_error=Trueattribute to theray.init()call like the failure suggests, it causes the test to misbehave since it initializes a ray cluster with a completely different number of CPUs.The fix is just as simple as adding this text fixture to tests, so that Ray isn't initialized by the test (only by the fixture) and it is calls the teardown function automatically at the end of each module.