resolve action name using the signature (#30) #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An object can have several methods or signature with the same name. This
is the case of the ALMotion.moveTo API. In such case we need to search
an action based on the name and the signature.
Unfortunatly QiLoop have concept of compatible signatures. Here is an
example of missmatch:
Until a proper signature comparison method is found, we rely on the
hack:
For methods, find the first with:
- name, param and return type
- name, param type
- name
For signals and properties:
- try to match both name and signature
- if not a tuple, convert to tuple and try again
- match only the name
This is clearly not satisfactory and a proper signature comparison
algorithm is needed. It can be cased on a flatten conversion to tuple.
Like: