Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom knob paths, and knob images #209

Merged
merged 14 commits into from Sep 15, 2019

Conversation

@wassup-
Copy link
Contributor

commented Sep 13, 2019

This pull request adds support for specifying custom knob paths. So instead of always having oval knobs, users can now for example draw polygons, squares, ... .

This pull request also adds support for drawing images in knobs, by allowing the user to specify both the image, insets and tint color.

This allows for some very nice effects, such as this

@luispadron

This comment has been minimized.

Copy link
Owner

commented Sep 14, 2019

Oh nice!
Thanks for this feature, I'm going to take a look at it now and see if we can get this merged in!

@luispadron luispadron self-requested a review Sep 14, 2019
Copy link
Owner

left a comment

Could you take a look at the comments I left, they're just simple fixes on your end. Also, please run swiftlint autocorrect, as there seems to be whitespace issues in the commits.

I'm going to look at why the tests are failing as I know the CI has been broken-ish for a bit. If you could as part of this PR add some tests as well that would be awesome. Otherwise, thanks so much for this I'm sure a lot of people will find this useful!

@luispadron

This comment has been minimized.

Copy link
Owner

commented Sep 14, 2019

Yep, so tests are failing due to lint issues. Make sure you have swiftlint installed and run it before committing changes as Travis will fail over lint issues.

convert tabs to spaces
@luispadron

This comment has been minimized.

Copy link
Owner

commented Sep 15, 2019

Merging this as it passes all tests except known faulty test. Thanks again!

@luispadron luispadron merged commit f54ef5f into luispadron:master Sep 15, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@luispadron

This comment has been minimized.

Copy link
Owner

commented Sep 15, 2019

Now available in 6.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.