Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference of Gaussian (DoG) edge detection added #59

Merged
merged 4 commits into from Apr 14, 2015

Conversation

wang1211
Copy link
Contributor

Another edge detection method besides sobel. DoG can approximate Laplacian of Gaussian operator. It works as an efficient edge detector.

Will add a demo soon.

Another edge detection method besides sobel. DoG can approximate Laplacian of Gaussian operator. It works as an efficient edge detector.
A demo is created to show the output of Sobel and Difference of Gaussian (DoG) edge operators.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.73%) to 96.4% when pulling 7ddcd9c on wang1211:master into cf3463f on luispedro:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.73%) to 96.4% when pulling 7ddcd9c on wang1211:master into cf3463f on luispedro:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.73%) to 96.4% when pulling 7ddcd9c on wang1211:master into cf3463f on luispedro:master.

@luispedro
Copy link
Owner

Thank you. This looks very good.

I think I can merge as is and add a simple test later or you if you have a test, that'd be nice too (also needed: a credit for you in the ChangeLog file).

Is the sigma2 = sigma1 * 1.001 relationship "standard" (used by other packages &c)? Should it be configurable?

Theoretically a small multiplier such as 1.001 should make it approximate Laplacian of Gaussian better. However, I have also seen people using large multiplier such as 2. So a configurable parameter might be desirable.
@wang1211
Copy link
Contributor Author

Thanks for the feedback. From what I have learned, 1.001 is not "standard" but a small multiplier such as 1.001 should make it approximate Laplacian of Gaussian better. However, after looking on the internet, I have also seen people using large multiplier such as 2. So a configurable parameter might be better in case users need it.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.73%) to 96.4% when pulling b3058d5 on wang1211:master into cf3463f on luispedro:master.

A filter is added as a convloving function. Calculate the Laplacian of a 2D array.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.95%) to 96.18% when pulling be7c509 on wang1211:master into cf3463f on luispedro:master.

@luispedro
Copy link
Owner

Thank you again. I think this all looks good and I'm merging now.

luispedro added a commit that referenced this pull request Apr 14, 2015
Difference of Gaussian (DoG) edge detection added
@luispedro luispedro merged commit 02afaec into luispedro:master Apr 14, 2015
@wang1211
Copy link
Contributor Author

Cool. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants