New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trailing slash to remove redirects. #112

Merged
merged 7 commits into from Nov 20, 2018

Conversation

Projects
None yet
3 participants
@tobinjt
Copy link
Contributor

tobinjt commented Nov 3, 2018

When you request /tags/foo, the web server will redirect you to
/tags/foo/ so the browser needs to make two requests. Add the trailing
slash in the link so that only one request is needed.

Add trailing slash to remove redirects.
When you request /tags/foo, the web server will redirect you to
/tags/foo/ so the browser needs to make two requests.  Add the trailing
slash in the link so that only one request is needed.
@crachel

This comment has been minimized.

Copy link

crachel commented Nov 4, 2018

Also needs it for /categories/foo/ since both point to directories.

@tobinjt

This comment has been minimized.

Copy link
Contributor Author

tobinjt commented Nov 5, 2018

Also needs it for /categories/foo/ since both point to directories.

Good point, added. Thanks :)

@luizdepra

This comment has been minimized.

Copy link
Owner

luizdepra commented Nov 6, 2018

Hmm... I need to check if there is a better way to solve this problem ratter than concatenating a /.

@luizdepra

This comment has been minimized.

Copy link
Owner

luizdepra commented Nov 19, 2018

@tobinjt, I just suggested two fixes.
Also, add yourself into CONTRIBUTORS.md.

luizdepra and others added some commits Nov 20, 2018

Improve how trailing slash is added.
Co-Authored-By: tobinjt <johntobin@johntobin.ie>
Improve how trailing slash is added.
Co-Authored-By: tobinjt <johntobin@johntobin.ie>
@tobinjt

This comment has been minimized.

Copy link
Contributor Author

tobinjt commented Nov 20, 2018

I've accepted those two fixes and added myself to CONTRIBUTORS.md, thanks!

@luizdepra

This comment has been minimized.

Copy link
Owner

luizdepra commented Nov 20, 2018

Thanks. :)

@luizdepra luizdepra merged commit d89edf3 into luizdepra:master Nov 20, 2018

1 check passed

deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment