Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd trailing slash to remove redirects. #112
Conversation
This comment has been minimized.
This comment has been minimized.
crachel
commented
Nov 4, 2018
Also needs it for /categories/foo/ since both point to directories. |
This comment has been minimized.
This comment has been minimized.
Good point, added. Thanks :) |
This comment has been minimized.
This comment has been minimized.
Hmm... I need to check if there is a better way to solve this problem ratter than concatenating a |
luizdepra
reviewed
Nov 19, 2018
luizdepra
reviewed
Nov 19, 2018
layouts/partials/taxonomy/tags.html Outdated
This comment has been minimized.
This comment has been minimized.
@tobinjt, I just suggested two fixes. |
luizdepra
and others
added some commits
Nov 20, 2018
This comment has been minimized.
This comment has been minimized.
I've accepted those two fixes and added myself to CONTRIBUTORS.md, thanks! |
luizdepra
approved these changes
Nov 20, 2018
This comment has been minimized.
This comment has been minimized.
Thanks. :) |
luizdepra
merged commit d89edf3
into
luizdepra:master
Nov 20, 2018
1 check passed
deploy/netlify
Deploy preview ready!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tobinjt commentedNov 3, 2018
When you request /tags/foo, the web server will redirect you to
/tags/foo/ so the browser needs to make two requests. Add the trailing
slash in the link so that only one request is needed.