Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #125

Merged
merged 1 commit into from Nov 29, 2018
Merged

Update PR template #125

merged 1 commit into from Nov 29, 2018

Conversation

@khos2ow
Copy link
Contributor

@khos2ow khos2ow commented Nov 29, 2018

This PR is going to update "PR template" as follow:

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

Description

This PR is updating pull_request_template.md.

Issues Resolved

List any existing issues this pull request resolves.

Checklist

Put an x into the box(es) that apply:

General

  • Describe what changes are being made
  • Explain why and how the changes were necessary and implemented respectively
  • Reference issue with #<ISSUE_NO> if applicable

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

Contributors

  • Add yourself to CONTRIBUTORS.md if you aren't on it already
@luizdepra
Copy link
Owner

@luizdepra luizdepra commented Nov 29, 2018

Looks good. Thank you.

@luizdepra luizdepra merged commit 1219798 into luizdepra:master Nov 29, 2018
5 checks passed
5 checks passed
Header rules No header rules processed
Details
Pages changed 55 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details
@khos2ow khos2ow deleted the khos2ow:update-pr-template branch Nov 29, 2018
agileup added a commit to agileup/hugo-coder that referenced this pull request Feb 25, 2019
* commit 'e66c1740611b15eee0069811d10b5a22b0dc4332': (66 commits)
  Remove hugow (luizdepra#146)
  Add missing built css files
  Fix pagination style (luizdepra#145)
  Add pt-br i18n (luizdepra#144)
  Add external link feature for posts (luizdepra#141)
  Fix hidden nav button on inverted (luizdepra#140)
  Easy customize (luizdepra#138)
  Add simple figure style for content class (luizdepra#130)
  Add Twitter Cards to each page (luizdepra#133)
  Fix multilingual home page avatar (luizdepra#134)
  Fix homepage main content section vertical align (luizdepra#118)
  Add missing pages
  Add HUGO_BIN into Makefile
  bug(base-url): change from site url to page url (luizdepra#131)
  Improve icons accessibility (luizdepra#127)
  Upgrade Hugo to v0.52/extended (luizdepra#124)
  Update PR template (luizdepra#125)
  Fix code indent (luizdepra#123)
  Revert flex on body
  Change copyright year to be current (luizdepra#121)
  ...

# Conflicts:
#	archetypes/posts.md
#	layouts/_default/baseof.html
#	layouts/partials/home.html
#	layouts/partials/post.html
#	static/css/style.min.css
#	static/less/colors.less
#	static/less/style.less
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.