New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Twitter Cards to each page #133

Merged
merged 4 commits into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@artspb
Copy link
Contributor

artspb commented Jan 5, 2019

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

Description

Hugo has an internal template for Twitter Cards. It takes necessary information from either site's or post's config thus it makes sense to add it to each page.

Issues Resolved

List any existing issues this pull request resolves.

Checklist

Put an x into the box(es) that apply:

General

  • Describe what changes are being made
  • Explain why and how the changes were necessary and implemented respectively
  • Reference issue with #<ISSUE_NO> if applicable

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

Contributors

  • Add yourself to CONTRIBUTORS.md if you aren't on it already

artspb added some commits Jan 5, 2019

Add Twitter Cards to each page
Hugo has an internal template for [Twitter Cards](https://gohugo.io/templates/internal/#twitter-cards). It takes necessary information from either site's or post's config thus it makes sense to add it to each page.
Add 'description' to posts archetype
This optional field is used by Twitter Cards.
@luizdepra

This comment has been minimized.

Copy link
Owner

luizdepra commented Jan 7, 2019

Looks good.
Could you please add the Twitter Card front matter to one or more posts?

Also, you should add yourselt into CONTRIBUTORS.md.

@artspb

This comment has been minimized.

Copy link
Contributor

artspb commented Jan 7, 2019

Done.

@luizdepra

This comment has been minimized.

Copy link
Owner

luizdepra commented Jan 7, 2019

Nice, ty.

@luizdepra luizdepra merged commit 3d4335a into luizdepra:master Jan 7, 2019

1 check passed

deploy/netlify Deploy preview ready!
Details

@artspb artspb deleted the artspb:patch-1 branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment