New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external link feature for posts #141

Merged
merged 2 commits into from Jan 17, 2019

Conversation

Projects
None yet
2 participants
@imtoori
Copy link
Contributor

imtoori commented Jan 17, 2019

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

Description

This adds the possibility to add an external link to a post. In this way the user can connect external articles (for example from Medium)

Issues Resolved

List any existing issues this pull request resolves.

Checklist

Put an x into the box(es) that apply:

General

  • Describe what changes are being made
  • Explain why and how the changes were necessary and implemented respectively
  • Reference issue with #<ISSUE_NO> if applicable

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

Contributors

  • Add yourself to CONTRIBUTORS.md if you aren't on it already
@luizdepra

This comment has been minimized.

Copy link
Owner

luizdepra commented Jan 17, 2019

Interesting. Just to be sure, Is the idea here to create an empty posts that redirect to a external source?
This will create a useless empty html file, but I don't know any better way to do it.

Also, please add a post example that uses the feature.

@imtoori

This comment has been minimized.

Copy link
Contributor Author

imtoori commented Jan 17, 2019

Yes, it's that.
You can see an example at https://salvatore-giordano.github.io/posts/

Anyway I'll add a post example

@luizdepra

This comment has been minimized.

Copy link
Owner

luizdepra commented Jan 17, 2019

Nice! Thank you.

@luizdepra luizdepra merged commit 7528f5b into luizdepra:master Jan 17, 2019

1 check passed

deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment