Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add see also section to posts footer #152

Merged
merged 2 commits into from Mar 11, 2019

Conversation

Projects
None yet
2 participants
@josephting
Copy link
Contributor

josephting commented Mar 8, 2019

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

Description

Posts that has series in its front matter will get listed at the footer of the post. Links to related posts of the same series will be listed beneath.

5 (configurable with seriesRelatedCount) related posts will be displayed by default. Had to add 1 in order to include the current post. Very bad practice but my hugo & golang knowledge is limited. Any help or advise are appreciated.

Issues Resolved

Resolves #150.

Checklist

Put an x into the box(es) that apply:

General

  • Describe what changes are being made
  • Explain why and how the changes were necessary and implemented respectively
  • Reference issue with #<ISSUE_NO> if applicable

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

Contributors

  • Add yourself to CONTRIBUTORS.md if you aren't on it already
@luizdepra
Copy link
Owner

luizdepra left a comment

I just want to make some minor modifications here.

Show resolved Hide resolved assets/scss/_content.scss Outdated
Show resolved Hide resolved exampleSite/config.toml Outdated

@josephting josephting force-pushed the josephting:series-related branch from 56f70f1 to 85f465d Mar 11, 2019

@josephting josephting force-pushed the josephting:series-related branch from 85f465d to c19bf71 Mar 11, 2019

@josephting

This comment has been minimized.

Copy link
Contributor Author

josephting commented Mar 11, 2019

I just want to make some minor modifications here.

@luizdepra Thanks for the review. Let me know if there's any other modifications needed.
The ul part css I didn't understand. Not sure how removing the class will fix it. 🤔

UPDATE: After testing it out with nav.list, I suppose the css override the browser default ul style. 👍

@luizdepra
Copy link
Owner

luizdepra left a comment

Well done. Thank you.

@luizdepra luizdepra merged commit 27e83b1 into luizdepra:master Mar 11, 2019

1 check passed

deploy/netlify Deploy preview ready!
Details

@luizdepra luizdepra referenced this pull request Mar 11, 2019

Closed

[v2] Series Taxonomy #58

@josephting josephting deleted the josephting:series-related branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.